Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Does not pass google closure advanced mode #16

Closed
Wu-Hao opened this Issue Dec 21, 2012 · 4 comments

Comments

Projects
None yet
4 participants
Contributor

Wu-Hao commented Dec 21, 2012

Google closure compiler advanced mode obfuscate codes.
commercial release has the need to protect their code

Please look into this to make chipmunk viable for commercial release

Owner

josephg commented Dec 21, 2012

You should closure compile your product together with the chipmunk library.
Then obfuscation won't break anything.

https://developers.google.com/closure/compiler/docs/api-tutorial3#separately
On 21 Dec 2012 13:42, "Wu-Hao" notifications@github.com wrote:

Google closure compiler advanced mode obfuscate codes.
commercial release has the need to protect their code

Please look into this to make chipmunk viable for commercial release


Reply to this email directly or view it on GitHubhttps://github.com/josephg/Chipmunk-js/issues/16.

Contributor

Wu-Hao commented Dec 21, 2012

this doesn't get past advanced mode:
E7 UDUYFFTZ0Y244IDD29PN
specifically

SegmentShape.prototype.collisionTable = [
    null,
    function(seg, seg) { return NONE; }, // seg2seg
    seg2poly
];
Owner

josephg commented Dec 21, 2012

Oh lol. Submit a pull request please.
On 21 Dec 2012 14:02, "Wu-Hao" notifications@github.com wrote:

this doesn't get past advanced mode:
[image: E7 UDUYFFTZ0Y244IDD29PN]https://f.cloud.github.com/assets/1455994/26199/7d162fe4-4b1a-11e2-935c-1af6e0bd9dfd.jpg
specifically

SegmentShape.prototype.collisionTable = [
null,
function(seg, seg) { return NONE; }, // seg2seg
seg2poly];


Reply to this email directly or view it on GitHubhttps://github.com/josephg/Chipmunk-js/issues/16#issuecomment-11601245.

@robwalch robwalch added a commit to robwalch/Chipmunk-js that referenced this issue Feb 1, 2013

@robwalch robwalch Duplicate param names changed. Fixes Issue #16 9a928b2
Contributor

robwalch commented Feb 1, 2013

This is fixed

@nornagon nornagon closed this Feb 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment