Add (optional) authentication step when connecting to share servers #128

Merged
merged 3 commits into from Oct 23, 2012

Conversation

Projects
None yet
3 participants
Contributor

daredevildave commented Sep 21, 2012

share.open() now accepts an object instead of a origin string.

The object can contains an 'authentication' property which will be attached the user agent. Use this to store an identifier for the user e.g. OAuth token and check for valid value in server's auth() function.

See https://github.com/daredevildave/authshare for example usage

Add (optional) authentication step when connecting to shares
share.open() now accepts an object instead of a origin string, The object can contains an 'authentication' property which will be attached the user agent. Use this to store an identifier for the user e.g. OAuth token
Contributor

daredevildave commented Sep 27, 2012

@wmertens and @josephg, do you have any comments on this? If you're happy I'll merge

Contributor

wmertens commented Oct 23, 2012

Yup looks great! Sorry for taking so long to respond...

daredevildave added a commit that referenced this pull request Oct 23, 2012

Merge pull request #128 from daredevildave/master
Add (optional) authentication step when connecting to share servers

@daredevildave daredevildave merged commit cf5f4af into josephg:master Oct 23, 2012

Contributor

mcolyer commented Nov 21, 2012

How should this work with reconnects across server restarts so you don't lose clients?

As far as I can tell browserchannel transparently reconnects behind the scenes and therefore can't reissue the auth message added in this pull upon connecting. Am I missing something?

mcolyer added a commit to mcolyer/ShareJS that referenced this pull request Nov 21, 2012

Revert "Merge pull request #128 from daredevildave/master"
This reverts commit cf5f4af, reversing
changes made to 4bd2896.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment