Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

authenticate() can pass custom error message to client through reject(msg) #133

Merged
merged 2 commits into from Oct 23, 2012

Conversation

Projects
None yet
4 participants
Contributor

dgreisen commented Oct 21, 2012

Now the authenticate() function can pass a custom error message to
the client by providing the message in action.reject(msg).
originally, rejection resulted in an unchangeable and not particularly
useful "forbidden" error.

includes tests

authenticate() can pass error message to client through reject(msg)
Now the authenticate() function can pass a custom error message to
the client by providing the message in action.reject(msg).
originally, rejection resulted in an unchangeable and not particularly
useful "forbidden" error.

includes tests
Contributor

CrypticSwarm commented Oct 21, 2012

+1

Owner

josephg commented Oct 21, 2012

Looks good, but I can't automerge. Can you update the diff?

Merge branch 'auth2' into orig
Conflicts:
	src/server/useragent.coffee
Contributor

dgreisen commented Oct 21, 2012

that should do it. let me know if there are still problems.

Contributor

wmertens commented Oct 23, 2012

Thanks!

wmertens added a commit that referenced this pull request Oct 23, 2012

Merge pull request #133 from dgreisen/auth2
authenticate() can pass custom error message to client through reject(msg)

@wmertens wmertens merged commit 4bd2896 into josephg:master Oct 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment