Simply use require #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And I think CI failure is unrelated here, right? |
|
The CI failure is related. This is the old form of require, needed before ruby 1.9 made require a little smarter. That said I don't think anyone is using 1.8 in the field really anymore, this seems like a fine change and the CI matrix should probably be modernized. |
|
@nextmat, I intend to open a new PR for modernizing CI :) |
Merged
|
Hi, |
|
@utkarsh2102 - thanks for the fix! this will be released in v0.2.3 shortly |
|
@utkarsh2102 - v0.2.3 was just released, apologize for the delay. I didn't previously have publishing rights for the gem we got that sorted, so I should be able to roll things out more quickly going forward. |
|
Awesome, thanks for your work! 🙌🏻❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes the method of requiring aggregate by changing
File.expand_pathmethod to simply usingrequire.This comes handy for downstream (at least, in maintaining the Debian package of this library), where the tests fail when built in a clean environment (schroot).
Hope this could be integrated here, as well :)
CC: @josephruscio @halorgium