Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate mysql and close a few issues #7

Merged
merged 7 commits into from
Jan 11, 2019
Merged

Conversation

josephspurrier
Copy link
Owner

No description provided.

@coveralls
Copy link

coveralls commented Jan 11, 2019

Pull Request Test Coverage Report for Build 13

  • 196 of 246 (79.67%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-7.6%) to 76.44%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/database/connection.go 21 23 91.3%
pkg/database/transaction.go 12 15 80.0%
reset.go 24 27 88.89%
migrate.go 23 27 85.19%
pkg/database/mysql.go 61 67 91.04%
status.go 11 19 57.89%
cmd/rove/main.go 18 30 60.0%
pkg/testutil/database.go 3 15 20.0%
Files with Coverage Reduction New Missed Lines %
cmd/rove/main.go 1 67.5%
Totals Coverage Status
Change from base Build 6: -7.6%
Covered Lines: 438
Relevant Lines: 573

💛 - Coveralls

@josephspurrier josephspurrier merged commit 37a2cca into master Jan 11, 2019
@josephspurrier josephspurrier deleted the separate-mysql branch January 11, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants