Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Feature/rails3 #11

Merged
merged 3 commits into from Nov 26, 2013

Conversation

Projects
None yet
2 participants
Contributor

todorus commented Nov 26, 2013

I wanted to use the rsemantic gem in a Rails app. Rails couldn't find the Semantic module as it assumes that it follows convention and was looking for an Rsemantic module. I've renamed the module Semantic to RSemantic so the gem can be used with Rails. All specs pass.

In addition I've replaced all deprecated RSpec functions with their modern replacemants.

Finally I've added Guard-RSpec for continues testing, but this is more a personal preference.

Owner

josephwilk commented Nov 26, 2013

Looks good, thanks!

@josephwilk josephwilk added a commit that referenced this pull request Nov 26, 2013

@josephwilk josephwilk Merge pull request #11 from todorus/feature/rails3
Feature/rails3
2a13c3c

@josephwilk josephwilk merged commit 2a13c3c into josephwilk:master Nov 26, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details

@josephwilk josephwilk added a commit that referenced this pull request Nov 26, 2013

@josephwilk josephwilk Revert "Merge pull request #11 from todorus/feature/rails3"
Some of the tests have gone rogue, reversing.

This reverts commit 2a13c3c, reversing
changes made to 634fd8f.
3c7b6a4
Contributor

todorus commented Nov 27, 2013

Thanks for reviewing, you'd be the one to notice. I'll have a retry later today (GMT+1) and be sure to review it more thoroughly.

@todorus todorus deleted the todorus:feature/rails3 branch Nov 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment