Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
Checking mergeability… Don’t worry, you can still create the pull request.
This comparison is big! We’re only showing the most recent 250 commits
Commits on Oct 06, 2015
@mperham mperham Remove racy assertion 42c3743
Commits on Oct 07, 2015
@mperham mperham Don't dispatch until all Processors are spun up 70bd688
@mperham mperham sleep to let thread die 26ac0e9
@mperham mperham Verify errors 3e90dc4
@mperham mperham Move server middleware stuff into Sidekiq module 8fc2cc6
@mperham mperham Remove actor, update requires 71eaac1
@mperham mperham Garbage optimizations 314a6b6
@mperham mperham cleanup da62019
@mperham mperham Remove sync stats update, move update into heartbeat 752bfc6
@mperham mperham Fix tests 89a1914
@mperham mperham Move fetching into the processor
This removes thread context switching and network delay.
56ea001
@mperham mperham fix merge bug 561d9d4
@mperham mperham Add 1ms of latency to benchmarks 3d80580
Commits on Oct 08, 2015
@mperham mperham Add latency to sidekiqload 69b0254
@mperham mperham merge load changes f8e6275
@mperham mperham load changes 862d44b
@mperham mperham Bump to 4.0 f9653e8
@mperham mperham Cleanup, tests passing da02fcb
@mperham mperham Fix quick shutdown, more cleanup 4a43865
@mperham mperham Add worker for testing latency 76e823a
@mperham mperham Merge branch 'master' into internal_rewrite f4c29b1
Commits on Oct 09, 2015
@mperham mperham Pick up concurrent-ruby fix 5e88414
@mperham mperham Fix tests 20fecf5
@mperham mperham Fix thread leak, fixes #2598 d62ee8f
@mperham mperham Prepare for release 069971a
@mperham mperham Give credit, #2598 9732de4
@mperham mperham merge master 1e9e209
@mperham mperham code shuffling and cleanup 8bc677f
Commits on Oct 10, 2015
@mperham mperham Merge pull request #2590 from natematykiewicz/master
Add favicon to UI and update status when polling
f277cae
@mperham mperham Promote Shutdown exception into main module 3e20710
Commits on Oct 12, 2015
@mperham mperham Don't allow delay usage on Sidekiq::Worker 242109e
@mperham mperham Move proctitles into CLI, so they can be accessed in startup events 9fc8267
Commits on Oct 13, 2015
@smolnar smolnar Remove redundant enclosing tag messing up styling e363a80
@smolnar smolnar Make form button groups look bit better bab1ab8
@mperham mperham 2.1.1 release ff287dd
@mperham mperham Merge pull request #2604 from smolnar/busy-page-styling-bug
Fix Styling Issues on Busy page
91c4065
@mperham mperham Free lifecycle procs so they GC 4fd83bf
Commits on Oct 14, 2015
@mperham mperham Make global stats processing gracefully handle errors 99a3194
@mhuggins mhuggins Automatically check for sidekiq.yml.erb filename 056444d
@mperham mperham Merge pull request #2605 from mhuggins/erb-config
Automatically check for sidekiq.yml.erb filename
0fd04ba
@mperham mperham Remove old poll_interval attribute 9a062a4
@mperham mperham initial 4.0 upgrade notes 789643c
@mperham mperham Formatting 9a88a1f
Commits on Oct 15, 2015
@mperham mperham Latest ent changes d173188
@mperham mperham Merge branch 'master' of github.com:mperham/sidekiq 052f67e
@mperham mperham release 0.7.4 19501b2
Commits on Oct 20, 2015
@mperham mperham touch the pool before startup event 6f1e0b0
Commits on Oct 21, 2015
@mperham mperham Verify Redis 2.8+ on startup d285f19
@mperham mperham Verify server connection pool is large enough for new fetch design 907828c
@mperham mperham Rework notes 879041b
@mperham mperham For safety, flushdb Redis before each test 9736321
@mperham mperham Found and killed the test suite instability.
Manager#processor_died test was spinning up a Processor in the background which ate jobs created in other tests!
58b2696
Commits on Oct 22, 2015
@mperham mperham merge master 87df35a
@mperham mperham 0.7.5 deca1dc
Commits on Oct 23, 2015
@kreynolds kreynolds Make exception available in #sidekiq_retry_in 2571086
@mperham mperham Merge branch 'master' into internal_rewrite 061bcde
@mperham mperham Remove deprecated method 2c81c48
@mperham mperham cleanup 18a513c
@mperham mperham Change old "message" terminology to "job" 93dddd7
@mperham mperham Prerelease version a04e9db
@mperham mperham Sidekiq Pro 3.0 release notes d239027
Commits on Oct 26, 2015
@mperham mperham Merge pull request #2619 from kreynolds/retry_with_exception
Make exception available in #sidekiq_retry_in
70d1892
@mperham mperham Merge branch 'master' into internal_rewrite eedd34b
@mperham mperham Latest changes 9c9c6ca
Commits on Oct 28, 2015
@mperham mperham ent changes a1270a2
@mperham mperham Merge branch 'master' into internal_rewrite 7149c9b
@mperham mperham Lock down 3.x b0d6069
@mperham mperham merge master 3318b89
@mperham mperham 4.0 changes 6ad6a3a
@mperham mperham ent 0.7.6 a087e1d
Commits on Oct 29, 2015
@mperham mperham pro 3.0 c65625d
@TheSmartnik TheSmartnik Replace kernel loop with while loop 2e660ae
@mperham mperham Merge pull request #2633 from TheSmartnik/master
Replace kernel loop with while loop
046f76a
Commits on Oct 30, 2015
@mperham mperham Increase the default server max connection pool size, #2634
4.0's fetch requires more connections.  Pro and Enterprise both have features requiring more connections.  This shouldn't matter too much in practice since connection_pool is lazy since 2.0 and will only create those extra connections if they are actually needed.
9db8fc0
@mperham mperham Merge branch 'master' of github.com:mperham/sidekiq 8744226
@mperham mperham death to email a1efeda
@mperham mperham latest 6698bdc
@mperham mperham Manager now fires stop-related events
Gives more fine-grained control as to when the actual event fires.  We also give a small bit of time for the event processors to take effect for those handlers with asynchronous side effects (like shutting down other threads and subsystems).
8ffdb36
@mperham mperham Any last words, Sidekiq? 595c616
Commits on Oct 31, 2015
@mperham mperham Execute shutdown event async from rest of system shutdown, fixes #2635 2022b6b
@mperham mperham merge 3_x 12ea27f
Commits on Nov 01, 2015
@mperham mperham Revert "Use Process.kill instead of `kill`"
This reverts commit ccc70d2.
041491e
@mperham mperham Revert "Use Process.kill instead of `kill`"
This reverts commit ccc70d2.
1ecb3a4
Commits on Nov 02, 2015
@mperham mperham 077 be99709
@mperham mperham pre2 with fixed shutdown race 0f9d418
@mperham mperham 300.pre2 c556c85
Commits on Nov 03, 2015
@mperham mperham 2.1.3 release notes 15dc306
Commits on Nov 05, 2015
@jdantonio jdantonio Latest concurrent-ruby release. 8939a27
@seuros seuros Merge pull request #2644 from jdantonio/cr-pre5
Latest concurrent-ruby release.
b11bc60
@jcavalieri jcavalieri Using percentage sizes for footer information with ellipses overflow.
Also added title attributes so on-hover shows full string.
e3c5ecc
@mperham mperham Merge pull request #2645 from jcavalieri/master
Using percentage sizes for footer information with ellipses overflow.
69c1687
@jcavalieri jcavalieri Using percentage sizes for footer information with ellipses overflow.
Also added title attributes so on-hover shows full string.
224259b
Commits on Nov 06, 2015
@mperham mperham Revert "Using percentage sizes for footer information with ellipses o…
…verflow."

This reverts commit 224259b.
0b125f1
@mperham mperham Merge branch '3_x' 4d0101d
@mperham mperham Revert "Using percentage sizes for footer information with ellipses o…
…verflow."

This reverts commit 224259b.
c5c74f4
@mperham mperham Maximize footer space, #2645 9cc5e8c
@jcavalieri jcavalieri footer tweaks, added title and ellipsis to url and namespace 331fc63
@jcavalieri jcavalieri be consistent with names d666ed6
Commits on Nov 07, 2015
@mperham mperham 1.0 notes ca57a84
Commits on Nov 09, 2015
@jcavalieri jcavalieri memoized d748836
@mperham mperham Merge pull request #2647 from jcavalieri/master
footer tweaks, added title and ellipsis to url and namespace
dd600a3
Commits on Nov 10, 2015
@sisnkemp sisnkemp Process.kill to check for process is more portable.
On OpenBSD, you can only use getpgid(pid) if the calling process
belongs to the same session as the the process with the PID `pid'.
Otherwise getpgid() returns EPERM.

Using kill(0, pid) is a more portable way to check whether a process
exists.
a6ea55d
@mperham mperham Merge pull request #2652 from sisnkemp/getpgid_to_kill
Process.kill to check for process is more portable.
8cac86b
Commits on Nov 12, 2015
@mperham mperham Fix script to work with pro and ent 3a687a1
@mperham mperham Less familiar 31ffe63
Commits on Nov 13, 2015
@simpl1g simpl1g Set redis-namespace gem as dev dependency 5dd62ac
@seuros seuros Merge pull request #2657 from simpl1g/master
Set redis-namespace gem as dev dependency
cc6af81
@mperham mperham Don't use ActiveSupport 04607f8
@mperham mperham Merge branch 'master' of github.com:mperham/sidekiq e213b63
@mperham mperham 078 dbd8bed
@brandonhilkert brandonhilkert Implements queue-based testing API
When using the Sidekiq::Client API to push jobs on to the queue, it's
not ideal to assert the size of the queue from the perspective of a
worker because the worker may not exist in the application.

This API implements a testing API from the perspective of a queue. The
existing Worker-based testing API remains unchanged, but leverages the
job hash implemented through the Sidekiq::Queues class.

Examples:

    assert_equal 1, Sidekiq::Queues["default"].size
    assert_equal "SpecialWorker", Sidekiq::Queues["default"].first["class"]
    Sidekiq::Queues["default"].clear
    Sidekiq::Queues.clear_all
321234e
@brandonhilkert brandonhilkert Can't use constantize if the worker doesn't exist ec00687
@brandonhilkert brandonhilkert Update documentation 9bad77f
@brandonhilkert brandonhilkert Run job inline during testing inline 19f9e05
@brandonhilkert brandonhilkert Fix name of test 66e1543
@brandonhilkert brandonhilkert Add documentation efda93c
@brandonhilkert brandonhilkert Remove association in changes update 901bbc7
@brandonhilkert brandonhilkert Unique all workers and ensure symbol queues are stringified via testing
API
df755bb
@brandonhilkert brandonhilkert Update code samples to be valid 785fcd5
@brandonhilkert brandonhilkert Send inline jobs through the same interface to process 4bac132
@mperham mperham Merge pull request #2659 from mperham/queue-testing-api
Implements queue-based testing API
df739ca
Commits on Nov 14, 2015
@mhenrixon mhenrixon Ensure comparison between strings
I have a lot of symbols in my code and so do others. This pull request
ensure that testing queus and jobs (just like production) are only ever
compared as strings.
d95f22e
@mperham mperham Merge pull request #2661 from mhenrixon/master
Ensure comparison between strings
fdb7ded
Commits on Nov 15, 2015
@mperham mperham concurrent-ruby 1.0! 078b2fa
@andrew andrew Remove nil qparams to avoid extra & in url generation 7077dbd
@mperham mperham Merge pull request #2662 from andrew/patch-1
Remove nil qparams to avoid extra & in url generation
c0b15eb
Commits on Nov 16, 2015
@mperham mperham major bump! fe43e1c
@mperham mperham Update 4.0-Upgrade.md 02ebe15
@mperham mperham Update 4.0-Upgrade.md b758661
@mperham mperham Update 4.0-Upgrade.md ea9eb42
Commits on Nov 17, 2015
@mperham mperham thanks @take-five 8e79e2d
@mperham mperham Merge branch 'master' of github.com:mperham/sidekiq 4008c17
@brandonhilkert brandonhilkert Revert "Merge pull request #2661 from mhenrixon/master"
This reverts commit fdb7ded, reversing
changes made to df739ca.
3cc996a
@brandonhilkert brandonhilkert Revert "Merge pull request #2659 from mperham/queue-testing-api"
This reverts commit df739ca, reversing
changes made to dbd8bed.
56ebcfd
@mperham mperham Merge pull request #2664 from mperham/remove-queue-api
Remove Queue Testing API due to incompatibility with Rspec
708db81
@mperham mperham 4.0.1 8577284
@brandonhilkert brandonhilkert Revert "Revert "Merge pull request #2659 from mperham/queue-testing-a…
…pi""

This reverts commit 56ebcfd.
6b277de
Commits on Nov 19, 2015
@mperham mperham bump 1598b24
Commits on Nov 21, 2015
@mperham mperham Add table to readme 3fdc51f
@mperham mperham tune a7d17f9
@mperham mperham enough hyperbole sir f1c127a
Commits on Nov 23, 2015
@mperham mperham Add namespace for 4.0 847438b
@mperham mperham Push a job to fill queue so we can delete it in UI d9776cd
Commits on Nov 25, 2015
@brandonhilkert brandonhilkert Merge branch 'master' into queue-api 2748b62
@brandonhilkert brandonhilkert Create separate data structures for queue and worker
Rspec allows expectations to be written using change(LogWorker.jobs,
:size). The result of .jobs in this case was a derived array that wasn't
manipulated under the covers. So when Rspec went to check the size of
the array after the fact, it appeared that nothing had changed.

This sets up a true array for the jobs for a single worker and
pulls jobs off that array so rspec can properly make assertions.
ed55232
@brandonhilkert brandonhilkert Add test to attempt to recreate Rspec syntax c4330cb
@brandonhilkert brandonhilkert Improve documentation 4004cf1
@brandonhilkert brandonhilkert Move changes to right version c4b0f7f
@mperham mperham Merge pull request #2676 from mperham/queue-api
Queue Testing API
1a42254
@mperham mperham bump version 9e130ff
Commits on Nov 30, 2015
@dlackty dlackty Use new hash syntax for generated spec 16d7b86
@davydovanton davydovanton Merge pull request #2679 from dlackty/patch-1
Use new hash syntax for generated spec
2b39111
Commits on Dec 01, 2015
@davydovanton davydovanton Fix unnecessary tabulation for minitest template file [skip ci] 32cead8
@seuros seuros Merge pull request #2682 from davydovanton/fix-minitest-template
Fix unnecessary tabulation for minitest template file
5df2da9
Commits on Dec 02, 2015
@arthurnn arthurnn Use minitest 5 parent class 5d90c3a
@seuros seuros Merge pull request #2685 from arthurnn/minitest_template
Use minitest 5 parent class
0379070
@mperham mperham Add complex workflow diagram for new wiki page ae88c7f
@mperham mperham Merge branch 'master' of github.com:mperham/sidekiq 98aa23e
Commits on Dec 04, 2015
@mperham mperham rdoc for #2691 dc8afa7
Commits on Dec 05, 2015
@pisaacs pisaacs Test against latest ruby patch versions 20c594e
Commits on Dec 06, 2015
@mperham mperham Merge pull request #2695 from pisaacs/pisaacs-test-against-latest-rub…
…y-patch-versions

Test against latest ruby patch versions
cdca996
Commits on Dec 08, 2015
@scalp42 scalp42 fix typos 2f3ac37
@scalp42 scalp42 thread is thread in french 1cf7377
Commits on Dec 09, 2015
@mperham mperham Merge pull request #2701 from scalp42/minor_typo_fix
fix typos
38f7414
@mperham mperham 3.0 8ad9212
@mperham mperham latest enterprise releases 0bb937b
@mperham mperham missed this new feature b561c37
@mperham mperham Display created_at, fixes #2705 2ad609b
Commits on Dec 11, 2015
@mperham mperham Safer exception message processing, fixes #2707
Use .to_s to allow a nil message, switch to [x, y] to avoid a range object allocation.
2cead06
@mperham mperham Merge branch '3_x' 7686012
Commits on Dec 14, 2015
@dreyks dreyks Display human-friendly class and args for ActionMailer jobs ef99c7a
@mperham mperham Merge pull request #2715 from dreyks/actionmailer
Display human-friendly class and args for ActionMailer jobs
76830ba
Commits on Dec 15, 2015
@davydovanton davydovanton Fix object allocation and cpu usage for each web request cc3beef
@mperham mperham Merge pull request #2716 from davydovanton/fix-object-allocation
Fix object allocation and cpu usage for each web request
6a53c7e
@davydovanton davydovanton Reduce object allocations for BasicFetch::UnitOfWork#queue_name fa1bd2c
@mperham mperham Merge pull request #2717 from davydovanton/reduse-allocation
Reduce object allocations in to 1/3 times
cc4e675
@mperham mperham Reduce object allocations, don't use unnecessary block form in hot path 7515878
Commits on Dec 18, 2015
@mperham mperham typo abe227d
Commits on Dec 21, 2015
@SamMolokanov SamMolokanov add absolute namespace for Rack::Protection 8bbcde6
@mperham mperham Merge pull request #2729 from SamMolokanov/fix/rack-namespace
add absolute namespace for Rack::Protection
7f88278
Commits on Dec 25, 2015
@seuros seuros test against ruby 2.3 6576db2
@seuros seuros Merge pull request #2734 from mperham/test-ruby-2.3
Test against ruby 2.3
f6aa249
Commits on Dec 31, 2015
@mperham mperham remove json, fixes #2743 b85e109
Commits on Jan 01, 2016
@ckersh ckersh Improve test coverage for handling signals c71c519
Commits on Jan 04, 2016
@mizoR mizoR Fix Japanese translation for `NoRetriesFound` 6db8b43
@davydovanton davydovanton Merge pull request #2747 from mizoR/fix-ja-translation-for-no-retries…
…-found

Fix Japanese translation for `NoRetriesFound`
f53b000
Commits on Jan 06, 2016
@ryohashimoto ryohashimoto Add Japanese translations 31edb66
@mperham mperham Merge pull request #2751 from ryohashimoto/160106_japanese
Add Japanese translations
bf70844
@mperham mperham Hack to speed up the test suite just a bit bf9ba44
@mperham mperham Clean up global state changes in custom web test, fixes #2752 f8baa8a
@mperham mperham time for 4.0.2 0f285f0
@mperham mperham bump 49affba
Commits on Jan 07, 2016
@yui-knk yui-knk Test against the newset version of ruby 2.1 (2.1.8) 5af4876
@seuros seuros Merge pull request #2754 from yui-knk/update_test_ruby_version
Test against the newset version of ruby 2.1 (2.1.8)
ee8d958
@jcarlson jcarlson Add "quiet" label to UI when process is quieted" 0c6466e
@jcarlson jcarlson fix tabs/spaces d267428
@jcarlson jcarlson fix tabs/spaces for real c2b260d
@jcarlson jcarlson Update stopping value every heartbeat 097eef9
@mperham mperham Merge pull request #2757 from jcarlson/quiet-ui
Add "quiet" label to UI when process is quieted"
6cebeef
@mperham mperham update changes 81ecefd
Commits on Jan 08, 2016
@ryohashimoto ryohashimoto Improve Japanese translations f0781e4
@mperham mperham Merge pull request #2758 from ryohashimoto/150106_better_japanese
Improved Japanese translations
6fd31f8
@mperham mperham pro 3.0.1 61dd819
@mperham mperham Merge branch 'master' of github.com:mperham/sidekiq a8bfe59
Commits on Jan 09, 2016
@davydovanton davydovanton Improve schedule test speed 1df36bc
@mperham mperham Merge pull request #2761 from davydovanton/times-map
Improve schedule test speed
559f848
Commits on Jan 12, 2016
@mperham mperham ent 1.1.0 dabe2f2
@mperham mperham Merge branch 'master' of github.com:mperham/sidekiq 0c21ece
Commits on Jan 13, 2016
@mperham mperham release 3.5.4 1a27202
@mperham mperham merge 3.x 4d6133f
Commits on Jan 14, 2016
@srecnig srecnig Fixed drain_all for workers with symbolized queue names in tests
The queue-based testing hash (@jobs_by_queue) stores the queue name as a string. Therefore, when a worker is given a symbol as queue name, deleting the job from the @jobs_by_queue silently fails, leaving the job in @jobs_by_queue (even though deleting succeded from the @jobs_by_worker). Sidekiq::Worker.drain_all gets the jobs through @jobs_by_queue, but since the josb are not removed after execution, calling drain_all will result in an endless loop.
ede0cdb
@ddrmanxbxfr ddrmanxbxfr Avoid recomputing range_size everytime in API 606cc7e
@davydovanton davydovanton Merge pull request #2771 from ddrmanxbxfr/MinorApiOptimization
Avoid recomputing range_size everytime in API
57ca17f
@ddrmanxbxfr ddrmanxbxfr Apply range_start optimization in SortedSet class 1e351b9
@davydovanton davydovanton Merge pull request #2772 from ddrmanxbxfr/MinorApiOptimization
Apply range_start optimization in SortedSet class
eb8e251
Commits on Jan 15, 2016
@mperham mperham Merge pull request #2770 from srecnig/master
Sidekiq::Worker.drain_all loops endlessly when queue name is symbolized
d191ac4
Commits on Jan 18, 2016
@mperham mperham Implement ActiveJob-style `set`, fixes #2780
The `set` method allows the user to dynamically override worker options without having to drop down to the Sidekiq::Client API, e.g.

    MyWorker.set(queue: 'foo').perform_async(1)
d6538b0
@mperham mperham Improved API rdoc 877b528
@mperham mperham Improve API rdoc 0f8c914
@mperham mperham ch-ch-ch-changes 3f6940b
Commits on Jan 19, 2016
@ckersh ckersh Add assertions for USR1, USR2, and TTIN signals 7c090d0
@ckersh ckersh Cleanup de405cc
@mperham mperham Improve shutdown speed a bit, fixes #2774 865d127
Commits on Jan 20, 2016
@mperham mperham Clarifying support channels 7119b49
@mperham mperham more support details fb5c311
Commits on Jan 21, 2016
@mperham mperham release notes b2dcfdd
@mperham mperham pro changes 93fd520
@mperham mperham fix build 7a69129
Commits on Jan 22, 2016
@mperham mperham Add code of conduct 9bd9f66
Commits on Jan 23, 2016
@Nowaker Nowaker Pass exception object to sidekiq_retries_exhausted block 15c18f6
Commits on Jan 26, 2016
@mperham mperham Log ALL of the middlewares! e664794
@Nowaker Nowaker Unit tests for sidekiq_retries_exhausted block 2eb4e5b
Commits on Jan 27, 2016
@mperham mperham Oops, use display_class here 5d5f1a8
@mperham mperham Merge pull request #2787 from virtkick/feature/exception-object-in-re…
…tries-exhausted-block

Pass exception object to sidekiq_retries_exhausted block
ad38803
@mperham mperham update changes dc3c690
Commits on Jan 28, 2016
@mperham mperham New ent feature 9a598a1
@mperham mperham bump version ac6c235
@mperham mperham pro changes e3f1c6f
Commits on Jan 29, 2016
@zedtux zedtux Update redis_connection.rb
Improve error message when the `redis-namespace` gem is missing with a namespace parameter.
03cb215
@mperham mperham Merge pull request #2802 from zedtux/patch-1
Update redis_connection.rb
fe5ec6f
Commits on Jan 30, 2016
@ckersh ckersh Need a logfile to reopen logs 53c7824
@mperham mperham Merge pull request #2745 from ckersh/test_coverage_handle_signal
Improve test coverage for handling signals
c131c1f
Commits on Feb 01, 2016
@mperham mperham notes for #2806 8761a23
Commits on Feb 04, 2016
@mperham mperham 2786 874fa09
Commits on Feb 05, 2016
@mperham mperham rejigger support, add newsletter link 5671dfd
Commits on Feb 06, 2016
@prokopsimek prokopsimek Update cs.yml
updated dead key and added missing keys from en locale
8e74272
@mperham mperham Merge pull request #2819 from prokopsimek/patch-1
Update cs.yml
1869d36
Commits on Feb 08, 2016
@mperham mperham aj testing d547c2a
@mperham mperham Merge branch '3_x' 05eaf0e
@mperham mperham pro notes 80bb648