Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
LogNotes does not work with standard ruby logger #98
In a Rails 3.2 app using Ruby 1.9, super is an ActiveSupport::TaggedLogging decorating ActiveSupport::BufferedLogger and finally a ::Logger, i.e. the standard Ruby logger. The #add method there is implemented like this
Note the return value. That's exactly what the PartialsNote gets: true. Instead of the intended, logged text. As a consequence, PartialsNote does not work in this configuration.
Incidentally, I'm wondering why the LogNotes looks at the log at all instead of subscribing to render_partial.action_view. Is this just a case of legacy code?