Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixes broken links to file in queries stack trace #97

Closed
wants to merge 1 commit into from

3 participants

@jerefrer

Before the fix the links had "&" instead of "&" in the url.

I just removed the "escape" surrounding the url. Was it actually useful in some way ?

@jerefrer jerefrer Fixes broken links to file in queries stack trace
Before the fix the links had "&" instead of "&" in the url.

I just removed the "escape" surrounding the url. Was it actually useful in some way ?
e2ac4b6
@romanvbabenko
Collaborator

needs some tests

@Intrepidd
Collaborator

This issue is really old and was created before a big refactoring, I'm closing this, if this is still needed please comment back or open a new PR, thanks !

@Intrepidd Intrepidd closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 21, 2013
  1. @jerefrer

    Fixes broken links to file in queries stack trace

    jerefrer authored
    Before the fix the links had "&" instead of "&" in the url.
    
    I just removed the "escape" surrounding the url. Was it actually useful in some way ?
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/rails-footnotes/notes/queries_note.rb
View
2  lib/rails-footnotes/notes/queries_note.rb
@@ -70,7 +70,7 @@ def alert_ratio
def parse_trace(trace)
trace.map do |t|
s = t.split(':')
- %[<a href="#{escape(Footnotes::Filter.prefix("#{Rails.root.to_s}/#{s[0]}", s[1].to_i, 1))}">#{escape(t)}</a><br />]
+ %[<a href="#{Footnotes::Filter.prefix("#{Rails.root.to_s}/#{s[0]}", s[1].to_i, 1)}">#{escape(t)}</a><br />]
end.join
end
end
Something went wrong with that request. Please try again.