Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Dec 23, 2013
  1. @senny

    Merge pull request #13427 from schneems/schneems/cannot-connect-postg…

    senny authored
    …res-error
    
    Tell how to Create a Database in Error Message
  2. @schneems

    Tell how to Create a Database in Error Message

    schneems authored
    Currently if you attempt to use a database that does not exist  you get an error:
    
    ```
    PG::ConnectionBad FATAL:  database "db_error" does not exist
    ```
    
    The solution is easy, create and migrate your database however new developers may not know these commands by memory. Instead of requiring the developer to search for a solution, tell them how to fix the problem in the error message:
    
    ```
    ActiveRecord::NoDatabase: FATAL:  database "db_error" does not exist
    Run `$ bin/rake db:create db:migrate` to create your database
    ```
    
    Active Record should not know about `rake db:migrate` so this additional information needs to come from the railtie. Potential alternative implementation suggestions are welcome.
  3. @carlosantoniodasilva
  4. @senny

    Merge pull request #13455 from jetthoughts/13445_fix_touch_destroyed_…

    senny authored
    …record
    
    On destroying do not touch destroyed belongs to association.
  5. @pftg
  6. @senny

    Merge pull request #13446 from kuldeepaggarwal/resolver-test-cases

    senny authored
    Resolver test cases
  7. @kuldeepaggarwal
  8. Merge pull request #13457 from strzalek/add-missing-av-railtie

    authored
    Add missing av/railtie require
Commits on Dec 22, 2013
  1. @strzalek
  2. @senny
  3. @senny

    Merge pull request #13451 from dmathieu/quoting_non_strings

    senny authored
    Fix typecasting array of integers
  4. @dmathieu

    fix quoting non-strings

    dmathieu authored
    Closes #13444
  5. @chancancode
  6. @pixeltrix
  7. @guilleiguaran
  8. @schneems
  9. @schneems

    Fix DB Console tests

    schneems authored
    The build is broken: https://travis-ci.org/rails/rails/builds/15824530
    
    This commit fixes it.
    
    The problem: Sqlite expects the `database` part to be an absolute path. That prompted this change to be committed to master: rails@fbb79b5
    
    This change provides correct behavior. Unfortunately tests were introduced in rails@971d510 that were relying on the incorrect behavior. We can avoid the fix by changing to another database url such as `mysql` or `postgresql`
    
    In addition to fixing the failure, the assertions are changed so that the "expected" value comes before "actual" value.
Commits on Dec 21, 2013
  1. @guilleiguaran

    Merge pull request #13438 from vipulnsward/enable-memache-on-travis

    guilleiguaran authored
    Enable memcached service on travis for running cache tests.
  2. @guilleiguaran

    Merge pull request #13436 from robin850/patch-11

    guilleiguaran authored
    Add missing changelog entries and fix few typos
  3. @vipulnsward
  4. @robin850
  5. @carlosantoniodasilva
  6. @robin850
  7. @fxn
  8. @robin850
  9. @fxn

    refactors AC::Parameters#fetch

    fxn authored
    AC::Parameters#fetch was refactored in 7171111 to prevent self mutation, but
    in doing so it hardcodes logic #convert_hashes_to_parameters is supposed to
    encapsulate.
    
    Better leave the delegation, and add a way to avoid mutating self in there.
  10. @guilleiguaran

    Test with 2.1.0-rc1

    guilleiguaran authored
  11. @dhh

    Merge pull request #13425 from kassio/master

    dhh authored
    Generates html and text templates for mailers by default.
  12. @fxn
  13. @tenderlove
Commits on Dec 20, 2013
  1. @kassio
  2. @rafaelfranca

    Merge pull request #13422 from rwz/master

    rafaelfranca authored
    Bump Jbuilder version to 2.0.0
  3. @rwz

    Bump Jbuilder version to 2.0.0

    rwz authored
  4. @senny

    Merge pull request #13415 from schneems/schneems/database-no-username

    senny authored
    Do not expect database user with app name to exist
  5. @mrkn @amatsuda

    Fix AS::NumberHelper results with large precisions

    mrkn authored amatsuda committed
    before:
      ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50
      => "3.14158999999999988261834005243144929409027099609375"
    after:
      ActiveSupport::NumberHelper.number_to_rounded '3.14159', precision: 50
      => "3.14159000000000000000000000000000000000000000000000"
Something went wrong with that request. Please try again.