Skip to content

José Valim
josevalim

Organizations

@rails @rack @plataformatec @elixir-lang @phoenixframework
May 25, 2016
josevalim commented on pull request elixir-lang/elixir#4683
@josevalim

Thank you @antipax! We should get feedback from @tonini and @msaraiva but I would stick with the following for formatting: lib/a.ex:2: A.a/0 lib/a.ex:

May 25, 2016
@josevalim
Dependency conversion error in umbrella
May 25, 2016
josevalim commented on issue elixir-lang/elixir#4684
@josevalim

From the umbrella project perspective, they are not being overridden because they are siblings. You need to make them consistent or override at the…

May 25, 2016
josevalim commented on issue elixir-lang/elixir#4682
@josevalim

@lexmag maybe one solution is to have the format diff function return a diff list, e.g. [eq: ..., less: ..., more: ..., [less: ...]] which can be a…

May 24, 2016
@josevalim

@lexmag emitting the diff for such cases become noise. :(

May 24, 2016
@josevalim

:normal, :shutdown and {:shutdown, _} are values defined by OTP for grateceful shutdown. The Supervisor docs have a session on them which we could …

May 24, 2016
@josevalim
May 24, 2016
@josevalim
  • @josevalim bdee464
    Do not emit diff for strings with bag difference > 0.6
May 24, 2016
@josevalim
Diffing algorithm is sometimes hard to parse
May 24, 2016
@josevalim
  • @josevalim db75c40
    Set default max connections to 16k instead of 1k, closes #402
May 24, 2016
@josevalim
fix max_connections setting documentation
May 24, 2016
josevalim commented on issue elixir-lang/elixir#4681
@josevalim

I agree 100%.

May 24, 2016
josevalim commented on issue elixir-lang/elixir#4668
@josevalim

Yes.

May 24, 2016
josevalim commented on pull request elixir-lang/elixir#4662
@josevalim

@ericmj please rebase and merge. :)

May 24, 2016
josevalim commented on issue elixir-lang/plug#402
@josevalim

Thank you, @fishcakez. I am still not sure. For all purposes 1024 still sounds too low but I am not sure of the downsides of defaulting to somethin…

May 24, 2016
@josevalim
  • @josevalim 7601de2
    Use tail recursive implementations for zip, take and take_while
May 24, 2016
@josevalim
Normalize precision and Calendar fields
May 24, 2016
josevalim commented on issue elixir-lang/elixir#4679
@josevalim

Thank you @lau! ❤️

May 24, 2016
josevalim commented on issue elixir-lang/elixir#4679
@josevalim

Adding "local" says nothing meaningful about the difference between the two. The same goes for Date and Time. There is nothing particular local ab…

May 24, 2016
@josevalim
Rename NaiveDateTime to LocalDateTime
May 24, 2016
josevalim commented on issue elixir-lang/elixir#4679
@josevalim

I don't think we have to cargo cult other projects only because they are old and big like Java. Old and big projects brought us "brilliant" ideas …

May 24, 2016
@josevalim

@bitwalker please validate the Calendar behaviour. Currently it contains three functions date/3, leap_year?/1 and to_string/1. The date/3 construct…

May 24, 2016
@josevalim
Add from_unix, to_unix and utc_now to DateTime
May 24, 2016
josevalim commented on issue elixir-lang/elixir#4674
@josevalim

Those functions have been added.

May 24, 2016
@josevalim
  • @josevalim 1287710
    Add Calendar.date/3 and DateTime.utc_now/0
May 24, 2016
josevalim commented on issue elixir-lang/elixir#4656
@josevalim

Perfect, we can work on --callers Foo.bar/1 next. Would --calls lib/foo.ex be useful to anyone at this point or not really?

May 24, 2016
@josevalim
  • @josevalim 476e331
    Use :calendar in to_unix and from_unix implementation
May 24, 2016
@josevalim
  • @josevalim 310f44c
    Add to_unix and from_unix to DateTime
May 24, 2016
@josevalim
  • @josevalim 4ba9707
    Provide Poison association encoding
May 24, 2016
@josevalim
  • @josevalim ec534fa
    Move Poison association encoding to Ecto
Something went wrong with that request. Please try again.