-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control_level slider. #40
Conversation
Can we accept this request? |
@mmarsalko Would you happen to be able to provide a binary for the non-Python inclined while we wait for a merge? 😅 |
Sorry, I wish I could, but I have no idea how to build it! The included build scripts use docker containers I don't have access to. 😬 |
Seeing as how the current build process for a |
thank you for this. The first line should start a bash instead of an sh. After changing that, it started to work for me. Unfortunately pyqt installationm then fails |
Seems to be a problem with |
As it looks like the author of cadmus has abandoned the project, I've forked it and merged in your fix @mmarsalko and I'm intending on keeping it up to date and working on this project in my spare time. If anyone would like to contribute, I'd like to invite you to do it on my repo so it will be looked after. To anyone else, you can find a release .deb to install with the fix at https://github.com/livkx/cadmus/releases |
Sorry, things have been crazy at work lately & I haven't had time for this. I'll merge this now & see what I can do about getting a release out tomorrow. |
@josh-richardson Right after I started trying to look after this project in my fork repo, assuming you’d gone MIA, you’ve returned 😁If you’re expecting to be too busy to look after this project, I’m happy to offer assistance in maintaining the repo and releases as I started doing on my fork. Feel free to email me noop@despacito.co.uk |
It would be good to have more than one person with the ability to merge pull requests & getting the releases out. |
So about the release? ._. |
So where are the official development and releases now? |
Released here: https://github.com/josh-richardson/cadmus/releases/tag/0.0.3 Will endeavor to be more active but have been working rather long hours lately. |
Hi, the slider doesn't appear in the latest AppImage provided on that tag. It's just...a blank box at the bottom. |
Same on Ubuntu 20.04 for me. |
No slider for me on Ubuntu 20.10 |
I decided to dig into the bug with Cadmus 0.2 not working on a lot of people's systems (including mine). Looks like the "control" value was missing, so I went ahead and added that back in, and made a slider so the user can set their own control level manually.
I've never messed with PyQt or pulse at this level, so it was a bit of fun learning how it all worked.
Hope you don't mind the cold PR out of nowhere. :)