New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker hub autotest #4

Merged
merged 2 commits into from Jan 7, 2019

Conversation

2 participants
@junian
Copy link
Contributor

junian commented Jan 7, 2019

No description provided.

@josh

josh approved these changes Jan 7, 2019

Copy link
Owner

josh left a comment

Your tests passed in Docker Cloud

Yeah! It looks like it passed on Docker Hub.

One small follow up suggestion, what if we changed the .travis.yml to build this compose file as well? Yeah, I realize it's running the same tests, but at least removes that setup duplication.

Maybe something like:

before_install:
  - docker-compose -f docker-compose.test.yml build

script:
  - docker-compose -f docker-compose.test.yml run sut
@junian

This comment has been minimized.

Copy link
Contributor

junian commented Jan 7, 2019

@josh Done!

@josh josh merged commit 2845bdb into josh:master Jan 7, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment