This repository has been archived by the owner. It is now read-only.

make sure the https redirect defaults to 443 #15

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

This is a small addition to pull request #7.

If the source url contains a port (e.g. http://example.com:8080) the current implementation generates a redirect to https://example.com:8080 which makes no sense.

This patch makes sure the redirect target contains no port information unless specified through the options, which means it should default to port 443.

make sure the https redirect defaults to 443
If the redirect source url contains a port e.g. (http://example.com:8080) the current implementation generates a redirect to https://example.com:8080 which seems pretty wrong to me in the general use case
Owner

josh commented Sep 25, 2012

You should probably just specify that port as an option.

@josh josh closed this Sep 25, 2012

That would be an solution but the default behavior (without a port) only works when the original request contains no port information (e.g. http://example.com).
As soon as the site was originally requested on a non standard port you get redirected to the same port with protocol 'https'. That makes no sense. Why leave it that way?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.