Change subdomain to host option #2

Merged
1 commit merged into from Feb 16, 2011

Conversation

Projects
None yet
1 participant
Contributor

qrush commented Feb 16, 2011

So a bug with my last patch was if you accessed a subdomain on http, you got redirected with that subdomain + the subdomain you specified...for example

http://ssl.example.com => https://ssl.ssl.example.com

I tried to keep the subdomain option to handle this, but parsing this kind of stuff is hard. Eventually I found https://github.com/pauldix/domainatrix but I don't think this library needs a dependency on it, so I just switched the :subdomain option to :host.

Contributor

qrush commented Feb 16, 2011

Woot, thanks Josh.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment