Permalink
Commits on Jan 19, 2015
  1. Fix bind value copying from subqueried relations

    With the old implementation, the bind values were created, and then we
    search the attributes for `Relation` objects, and merge them. This
    completely ignores the order that the actual `where` clause will use. If
    all non-relation where parameters are before the relations, it will
    work. However, if we query on both a relation and a value, with the
    value coming second, it breaks. The order of the hash should not affect
    the final query (especially since hashes being ordered is an
    implementation detail)
    sgrif committed Jan 19, 2015
  2. Move `create_binds` over to the `PredicateBuilder`

    I'm looking to introduce a `WhereClause` class to handle most of this
    logic, and this method will eventually move over to there. However, this
    intermediate refactoring should make that easier to do.
    sgrif committed Jan 19, 2015
  3. Whether a column exists or not doesn't affect whether we can use binds

    Looking through the blame, this logic used to be when we actually
    created the bind tuple. My guess is that `nil` couldn't be handled there
    at that time. It can, now.
    sgrif committed Jan 19, 2015
  4. Don't mutate bind values in `Relation`

    In order to better facilitate refactoring, most places that mutated
    `bind_values` have already been removed. One last spot snuck through.
    Since we're no longer mutating the array, it also does not need to be
    duped in `initialize_copy`.
    sgrif committed Jan 19, 2015
  5. Merge pull request #18450 from tonytonyjan/patch-1

    fix dependency
    rafaelfranca committed Jan 19, 2015
  6. Merge pull request #18593 from prathamesh-sonpatki/ar-changelog

     Fix wording in AR CHANGELOG about time columns change [ci skip]
    senny committed Jan 19, 2015
  7. Merge pull request #18594 from prathamesh-sonpatki/use-force-true-in-…

    …templates
    
     Use force: true options for creating tables in bug templates
    senny committed Jan 19, 2015
  8. Merge pull request #18600 from y-yagi/fix_number_field_tag_example

    fix typo in number_field_tag documentation [ci skip]
    seuros committed Jan 19, 2015
  9. Use force: true options for creating tables in bug templates

     - Generally we have to run the bug templates multiple times to get them
       right and it always complains because the posts and comments tables
       already exist due to earlier runs.
     - Using force: true will eliminate this issue.
    prathamesh-sonpatki committed Jan 19, 2015
  10. Merge pull request #18483 from rono23/fix-name_for_action-in-routing

    Fix name_for_action in routing
    spastorino committed Jan 19, 2015
  11. Merge pull request #18380 from nobu/Use-EXEEXT

    Use EXEEXT
    spastorino committed Jan 19, 2015
  12. Fix name_for_action in routing

    rono23 committed Jan 13, 2015
Commits on Jan 18, 2015
  1. Merge pull request #18591 from kamipo/remove_unused_accessor

    Remove unused accessor
    spastorino committed Jan 18, 2015
  2. Merge pull request #18501 from prathamesh-sonpatki/nosql

     Run SQL only if attribute changed for update_attribute method
    spastorino committed Jan 18, 2015
  3. Remove unused accessor

    kamipo committed Jan 12, 2015
  4. Merge pull request #18586 from kamipo/should_escape_regexp_wildcard_c…

    …haracter
    
    Should escape regexp wildcard character `.`
    fxn committed Jan 18, 2015
  5. Should escape regexp wildcard character `.`

    `.` is regexp meta character. It should be escape for `assert_match`
    correctly.
    kamipo committed Jan 18, 2015
  6. Don't calculate in-place changes on attribute assignment

    When an attribute is assigned, we determine if it was already marked as
    changed so we can determine if we need to clear the changes, or mark it
    as changed. Since this only affects the `attributes_changed_by_setter`
    hash, in-place changes are irrelevant to this process. Since calculating
    in-place changes can be expensive, we can just skip it here.
    
    I also added a test for the only edge case I could think of that would
    be affected by this change.
    sgrif committed Jan 18, 2015
  7. Use bundler 1.7 on travis

    sgrif committed Jan 18, 2015
  8. Run SQL only if attribute changed for update_attribute method

     - This is based on rails#18400 but
       tackling same issue with update_attribute method instead of update method.
    prathamesh-sonpatki committed Jan 11, 2015
  9. Merge pull request #18576 from yui-knk/fix/autoload4

    [ci skip] Move a introduction of `Module.nesting`
    spastorino committed Jan 18, 2015
  10. Merge pull request #18579 from prathamesh-sonpatki/use-existing-const…

    …ant-for-join
    
    Use existing constant for joining instead of '_'
    spastorino committed Jan 18, 2015
  11. Merge pull request #18578 from y-yagi/remove_logger_extensions

    remove reference to `Logger` core extensions from guide [ci skip]
    seuros committed Jan 18, 2015
  12. Merge pull request #18577 from prathamesh-sonpatki/nodoc-av-modelnaming

    nodoc ActionView::ModelNaming module
    guilleiguaran committed Jan 18, 2015
  13. nodoc ActionView::ModelNaming module

    - Its only used by ActionView internals and not supposed to be used
      through public API.
    prathamesh-sonpatki committed Jan 18, 2015
  14. Merge pull request #18575 from yui-knk/fix/autoload

    [ci skip] fix positions of parentheses
    zzak committed Jan 18, 2015
  15. [ci skip] Move a introduction of `Module.nesting`

    Move a introduction of `Module.nesting` to the beginning of sentence.
    This change will help reader to try to dump `nesting`.
    yui-knk committed Jan 18, 2015
Commits on Jan 17, 2015
  1. Merge pull request #18569 from yuki24/eliminate-warning-in-action-vie…

    …w-test
    
    Eliminate a ruby warning in a test in Action View
    senny committed Jan 17, 2015
  2. Eliminate a ruby warning in a test in Action View

    This eliminates the warning below:
    
      actionview/test/template/form_helper_test.rb:913: warning: method redefined; discarding old id_came_from_user?
      actionview/test/template/form_helper_test.rb:104: warning: previous definition of id_came_from_user? was here
    yuki24 committed Jan 17, 2015