Permalink
Commits on Apr 19, 2013
  1. CSS built (previous commit changed CSS)

    François Daoust
    François Daoust committed Apr 19, 2013
  2. "Share" icon displayed in detail page in phone version

    François Daoust
    François Daoust committed Apr 19, 2013
    The "share" icon gets displayed when the user accesses a details page,
    it allows to share the item.
    
    The "share" icon is displayed in the topbar at the same position as
    the "refresh" icon.
    
    In a proper implementation, the "share" icon would only be displayed
    if there is a "share" add-on. Clicking on that icon would start the
    "share" activity. Right now, add-ons are not checked and the hook is
    not triggered. The action needs to be hardcoded in the "share"
    function of "sleek.phone.js".
    
    Notes:
    - the icon is a copy of the "refresh" icon for the time being,
    pending a better icon.
    - the case when a datasource contains only one item is not supported,
    meaning the "refresh" icon will be displayed in that case, not the
    "share" icon.
    - the case when the item cannot be shared (static local content) is
    not supported either, meaning the "share" icon is always displayed.
Commits on Apr 17, 2013
  1. Title does not mask toolbar clicks on IE9 anymore (desktop). Bump ver…

    Clément Vollet
    Clément Vollet committed Apr 17, 2013
    …sion.
    
    The #title span was blocking the clicks because it was put over the
    toolbar and had a property display:inline (default one).
    
    By changing the property to inline-block, the element is not masking
    the toolbar anymore.
    
    Related to https://www.pivotaltracker.com/story/show/45389923
  2. Do not show toolbar when there is only one datasource (bis).

    Clément Vollet
    Clément Vollet committed Apr 17, 2013
    Since the new update to the view and the introduction of the hidden
    property, this was broken. Indeed, the view now applies directly a
    jQuery.show to its element. We used a "display:none" in the css
    to hide the toolbar when needed.
    
    To circumvent that, we now use "visibility:hidden".
    
    This should fix https://www.pivotaltracker.com/story/show/29702415 for good.
Commits on Apr 12, 2013
  1. Template built. v1.3.4

    François Daoust
    François Daoust committed Apr 12, 2013
    Changelog:
    - Fixed broken background color in tablet/desktop versions
  2. Fixed background color issue in Tablet/Desktop versions

    François Daoust
    François Daoust committed Apr 12, 2013
    The bug was due to the fact that changes made to the main HTML content
    had not been applied to the optimized versions of the HTML pages.
    
    Related bug in Pivotal:
    https://www.pivotaltracker.com/story/show/47881841
Commits on Apr 10, 2013
  1. Template built. v1.3.3

    François Daoust
    François Daoust committed Apr 10, 2013
    Changelog:
    - Fixed flickering when loading/switching tab on iPad retina devices
  2. Fixed flickering effect on iPad retina when loading/switching tabs

    François Daoust
    François Daoust committed Apr 10, 2013
    The flickering effect occurred because the toolbar gets rendered more
    than once for some reason. In the end, the solution was to force the
    rendering of the toolbar through the GPU.
    
    I took the opportunity of the change to simplify the rendering of the
    toolbar a bit as it was using a combinaison of floats and absolute
    positioning that was not really necessary.
    
    The utils.less now features a ".accelerate" shortcut. Note that
    setting "backface-visibility" to "hidden" is not enough anymore
    to force an element through the GPU on iPad retina devices. The
    shortcut gets replaced by a combinaison of "backface-visibility",
    "perspective" and "translateZ". They should not all be needed but
    that should not have any drawback in practice.
Commits on Apr 9, 2013
  1. Template built. v1.3.2

    François Daoust
    François Daoust committed Apr 9, 2013
    Changelog:
    - fixed single video content dimensions upon first render
    - fixed visuals on IE9
  2. Single video datasource: fixed available width/height computation

    François Daoust
    François Daoust committed Apr 9, 2013
    The "getContentWidth" and "getContentHeight" functions assumed that
    all tabs were composed of a list and detail views but that is no
    longer the case as some of the tabs may only contain a detail view.
    
    The code of these functions had to check the dimensions of the
    detail view because, many commits before the latest one, the
    width of a slide panel in the framework was not the width of the
    viewport but the sum of all the widths of the panels it contained.
    That is no longer the case, we can now simply check the dimensions
    of the container element to determine the available width and height.
  3. Make sleek looks ok on IE9.

    Clément Vollet
    Clément Vollet committed Apr 9, 2013
    With this change, IE9 should properly render all element. There is no gradient, since we don't want to use the non-standard filter css property. Only the background color of the toolbar was not being set, hence IE9 displaying a quite ugly white toolbar.
    
    This fixes https://www.pivotaltracker.com/story/show/45389923
  4. Template built. v1.3.1

    François Daoust
    François Daoust committed Apr 9, 2013
    Changelog:
    - fixed desktop version
    - better show/hide view support to avoid useless view repaints
  5. Ensured sections are created in a "hidden" state.

    François Daoust
    François Daoust committed Apr 9, 2013
    During application startup, all the sections were displayed at once
    one on top of the others with a spinner up until the first route was
    executed.
    
    Also switched to the latest version of the framework that handles the
    "hidden" initialization option and that also does not update the DOM
    for nothing when the code calls "show/hide" whereas hidden state is
    already correct.
  6. Fixed startup crash on desktop in optimized version of the template

    François Daoust
    François Daoust committed Apr 9, 2013
    For some reason, there is a difference in behavior between the non
    compiled version and the compiled version of the "onReady" utility
    toolbelt. In the compiled version on desktops, it sends in the
    underyling event as first parameter.
    
    The Sleek.initialize function takes a potential callback function as
    first parameter. The template crashed when it received the event
    object. I updated the code to ensure that the initialize function
    never receives the event object.
    
    Related bug in Pivotal:
    https://www.pivotaltracker.com/story/show/47715579
Commits on Apr 8, 2013
  1. Template built. v1.3.0.

    François Daoust
    François Daoust committed Apr 8, 2013
  2. Fixed Samsung version (to be tested on actual devices!)

    François Daoust
    François Daoust committed Apr 8, 2013
    The Samsung TV version now derives from the TV version of Sleek to
    maximize the amount of code that is shared across versions, as most
    of the code of the Samsung TV version was actually a copy and paste
    of the code of the default TV version.
    
    The "load more" feature should now also work on the Samsung version.
    
    I haven't checked the code on an actual device. While the update does
    not bring anything "worrysome" in the sense that the updates do not
    change a lot from a rendering perspective, history shows that the
    template is likely still broken in practice ;)
  3. Improved empty feed support. Ensured views are rendered only once

    François Daoust
    François Daoust committed Apr 8, 2013
    The commit brings in the latest version of the framework that
    provides a more consistent update mechanism across views that do not
    force a full refresh when not needed.
    
    Sleek now renders views once when they get created. Updates made to
    the models and collections bound to the views trigger the additional
    magic needed to update the content displayed. This is probably not
    enough to fix the flickering effect on iPads, but that should still
    improve things and avoid useless updates that could happen in the
    past.
    
    Samsung TV version still not operational.
Commits on Apr 5, 2013
  1. Samsung TV image collection now derives from joshlib!collection

    François Daoust
    François Daoust committed Apr 5, 2013
    The specific image collection is useful to filter out images that
    are too large as Samsung TV models tend to crash when requested to
    render such images.
    
    The collection used to derive from Backbone.Collection directly
    but the "joshlib!collection" class now adds useful logic to fetch
    more items in a collection and to trigger load events when new items
    are fetched.
  2. Switched to latest version of the framework (rendered, update, remove)

    François Daoust
    François Daoust committed Apr 5, 2013
    The latest version of the framework brings a better tracking of
    views, in particular for the DynamicContainer view.
    
    Things that still do not work well:
    - The Samsung version is borked. More fixes needed. The code has not
    been updated to drop the "<li>" level to start with and the specific
    "collection" needs to derive from "joshlib!collection".
    - The flickering effect should still be around. Ghost views are not
    kept around anymore, which is good, but they are still created
    temporarily. It should be easier to track things down now that we
    have better logs.
  3. A couple of traces added to ease debugging

    François Daoust
    François Daoust committed Apr 5, 2013
  4. New version.

    Clément Vollet
    Clément Vollet committed Apr 5, 2013
    Includes work done on the load more by François, and the tap to scroll for the ios version.
Commits on Apr 4, 2013
  1. More Woodman traces added

    François Daoust
    François Daoust committed Apr 4, 2013
  2. Merge branch 'master' of git://github.com/joshfire/factory-template-s…

    Clément Vollet
    Clément Vollet committed Apr 4, 2013
    …leek
    
    Conflicts:
    	app/joshfire-framework
    	app/sleek.js
    	app/sleek.phone.js
  3. Make sleek work with the taptoscroll plugin. This needs modification …

    Clément Vollet
    Clément Vollet committed Apr 4, 2013
    …to the factory before it can be used. Once the factory work is done and in prod, we can advertise that feature.
Commits on Apr 3, 2013
  1. Fetch more: framework updated to fix TV grid and vertical list

    François Daoust
    François Daoust committed Apr 3, 2013
    The TV views did not properly update themselves when new items were
    added to the underlying list because they had no real way to know
    when the new children were rendered. The new "render:children" event,
    trigger by the List view, makes it now easy to detect when rendering
    is over.
    
    Related feature in Pivotal:
    https://www.pivotaltracker.com/story/show/45390535
  2. Merge branch 'master' of github.com:joshfire/factory-template-sleek

    François Daoust
    François Daoust committed Apr 3, 2013
    Conflicts:
    	app/joshfire-framework
    	app/less/overwrite.less
    	app/sleek.js
  3. "Load more" improved. Framework updated. Woodman logs added.

    François Daoust
    François Daoust committed Apr 3, 2013
    Switched to the latest version of the framework that handles the
    "load more" feature more generically with a "loading more" class
    name. and trigger the appropriate events on the collection itself
    instead of on the List view.
    
    The "app/woodmanConfig.js" file contains a default Woodman
    configuration that activates logs on the framework as well. This is
    for debugging purpose. All references to Woodman should disappear
    when the template is built.
    
    CSS and template not yet built.
    
    Two main bugs remain:
    - There are a couple of hiccups on the grid and vertical list views
    in the TV version when new items get added to the lists
    - The use of DynamicContainer means that list views are created
    twice internally. It does not impact the app from a visual perspective
    although this may be the cause for the flickering on iPad devices. It
    does impact the performance of the app somehow (the ghost views
    respond to the events triggered by the underlying collection).
  4. Sleek not compatible with IE9

    Clément Vollet
    Clément Vollet committed Apr 3, 2013
Commits on Apr 2, 2013
  1. New version

    Clément Vollet
    Clément Vollet committed Apr 2, 2013
  2. Dailymotion videos not refreshed after tab change

    Clément Vollet
    Clément Vollet committed Apr 2, 2013
  3. When only one datasource, do not display tabs.

    Clément Vollet
    Clément Vollet committed Apr 2, 2013
Commits on Mar 27, 2013
  1. Bumped version of framework to incorporate "load more" fixes

    François Daoust
    François Daoust committed Mar 27, 2013
    In particular, the "load more" icon was not removed from the view
    when the function did not return any item.
    
    Related story in Pivotal:
    https://www.pivotaltracker.com/story/show/45390535
  2. Template built. Version incremented to v1.2.23

    François Daoust
    François Daoust committed Mar 27, 2013