Skip to content

fix errormarkerclass for nested array #102

merged 1 commit into from Jan 3, 2014

2 participants

flisky commented Dec 31, 2013

No description provided.

@tidoust tidoust pushed a commit that referenced this pull request Jan 3, 2014
François Daoust Fine-tuned fix of errormarkerclass for nested arrays (#67 and #102)
Many thanks for the pull request, @flisky. The line you fixed was
indeed the line that caused problem. However, while the "g" flag is
indeed needed to support nested arrays, that was not enough to
produce the right output.

Typically, the goal is to generate something like "map[0][0].index"

The first two regular expressions turn the input into:

Just adding the "g" flag to the final regular expression woud not
really change anything in most cases, leading to:

The following "." should not have been part of the match, I added the
right lookahead pattern. That seems to work fine in the forms I tried.
@tidoust tidoust merged commit 4004f14 into joshfire:master Jan 3, 2014
flisky commented Jan 3, 2014


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.