Distro install enhancements #18

Merged
merged 4 commits into from Feb 8, 2012

2 participants

@larzconwell

I just added an if/else statement to the imagemagick and git installs so that it only tries to install it if not already installed.

Also made simpler recipes path when downloading the distro files.

@joshfng
Owner

This looks great! There's one small fix that needs to take place though. If you make that change I'd be happy to merge this. Thanks!

@larzconwell

Oops yeah I forgot about the dollar signs for the variables, i'll get that fixed when I get home!

@larzconwell

Okay I fixed it! That was a bit embarrassing.

@joshfng
Owner

Looks good. I'll merge this and run it through the tests tonight. Thanks!

@larzconwell

No, thank you! Also the if/else statements for the installs should work for OS X as well, but I can't confirm it.

@joshfng joshfng merged commit c842af6 into joshfng:master Feb 8, 2012
@joshfng joshfng added a commit that referenced this pull request Feb 8, 2012
@joshfng Revert "Merge pull request #18 from larzconwell/master" due to failin…
…g test on fresh install of Ubuntu.

This reverts commit c842af6, reversing
changes made to d79902e.
56687f4
@joshfng
Owner

Just merged this and tested it on a fresh install of Ubuntu. The tests for convert and git are giving false positives. On a fresh install the conditionals think imagemagick and git are already installed and therefore don't attempt to install them. Feel free to work on this if you like. I would suggest changing the paths in your fork to point to your repo and experimenting with your fork on a fresh vm until it works. What I do is install Ubuntu in virtualbox and create a snapshot called "pre rails ready". Then I run the script and when I'm done testing I restore the vm to "pre rails ready". This allows me to test again and again on a fresh install without ever having to reinstall the os :)

@larzconwell

Yeah I just tried that on Debian and OpenSuse and the it spits out a which error. I'll see what I can do to get passed that.

That's what i've been doing too! That shortcut for the recipes path helps quite a bit with it as well haha

@larzconwell

Oh I got it, it's because there's only one set of brackets around it, and it returns too many arguments.

If I replace it with two brackets, it's working for me. I'm gonna test it on all these other distros then see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment