fixes #59, baseurl to resolve // issue #60

Closed
wants to merge 125 commits into
from

Conversation

Projects
None yet
5 participants

lukemcgregor added some commits Apr 12, 2017

Make it so that you can override canonical for page
Useful if you are running a test site or similar
Merge pull request #1 from lukemcgregor/canonical-overide
Make it so that you can override canonical for page
Merge pull request #3 from lukemcgregor/empty-tags
If no tags present, don't show `. On`
Cache buster for main.css and main.js
So that if they are changed you dont need a hard reload, see
https://toddmotto.com/cache-busting-jekyll-github-pages
@twitchett

This comment has been minimized.

Show comment
Hide comment
@twitchett

twitchett Apr 15, 2017

Hey, thanks a bunch for this fix, it's exactly what I needed. I had my baseurl set to '' a lot of things were broken. Works perfectly now.

Hey, thanks a bunch for this fix, it's exactly what I needed. I had my baseurl set to '' a lot of things were broken. Works perfectly now.

@lukemcgregor

This comment has been minimized.

Show comment
Hide comment
@lukemcgregor

lukemcgregor Apr 15, 2017

Contributor

No problem glad it helped :)

Contributor

lukemcgregor commented Apr 15, 2017

No problem glad it helped :)

@joshgerdes

This comment has been minimized.

Show comment
Hide comment
@joshgerdes

joshgerdes Jul 7, 2017

Owner

Not sure what's going on with this PR but seems like you should not need this many commits or changes to fix this possible issue. Closing, feel free to reopen if you have a specific issues to fix.

Owner

joshgerdes commented Jul 7, 2017

Not sure what's going on with this PR but seems like you should not need this many commits or changes to fix this possible issue. Closing, feel free to reopen if you have a specific issues to fix.

@joshgerdes joshgerdes closed this Jul 7, 2017

@lukemcgregor

This comment has been minimized.

Show comment
Hide comment
@lukemcgregor

lukemcgregor Jul 7, 2017

Contributor

hang on @joshgerdes i just broke it 5 mins ago, about to unbreak

Contributor

lukemcgregor commented Jul 7, 2017

hang on @joshgerdes i just broke it 5 mins ago, about to unbreak

@lukemcgregor lukemcgregor deleted the lukemcgregor:baseurl branch Jul 7, 2017

@adishavit

This comment has been minimized.

Show comment
Hide comment
@adishavit

adishavit Sep 4, 2017

@lukemcgregor : These two lines make the GitHub Jekyll choke and email me with:

The page build failed for the `master` branch with the following error:

Your SCSS file `css/main.scss` has an error on line 42: Invalid CSS after " border-collapse": expected ";", was ": collapse;". For more information, see https://help.github.com/articles/page-build-failed-invalid-sass-or-scss/.

For information on troubleshooting Jekyll see:

  https://help.github.com/articles/troubleshooting-jekyll-builds

If you have any questions you can contact us by replying to this email.

@lukemcgregor : These two lines make the GitHub Jekyll choke and email me with:

The page build failed for the `master` branch with the following error:

Your SCSS file `css/main.scss` has an error on line 42: Invalid CSS after " border-collapse": expected ";", was ": collapse;". For more information, see https://help.github.com/articles/page-build-failed-invalid-sass-or-scss/.

For information on troubleshooting Jekyll see:

  https://help.github.com/articles/troubleshooting-jekyll-builds

If you have any questions you can contact us by replying to this email.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment