Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #59, baseurl to resolve // issue #60

Closed
wants to merge 125 commits into from

Conversation

@lukemcgregor
Copy link
Contributor

lukemcgregor commented Apr 13, 2017

lukemcgregor added 30 commits Apr 12, 2017
Useful if you are running a test site or similar
Make it so that you can override canonical for page
If no tags present, don't show `. On`
So that if they are changed you dont need a hard reload, see
https://toddmotto.com/cache-busting-jekyll-github-pages
@joshgerdes
Copy link
Owner

joshgerdes commented Jul 7, 2017

Not sure what's going on with this PR but seems like you should not need this many commits or changes to fix this possible issue. Closing, feel free to reopen if you have a specific issues to fix.

@joshgerdes joshgerdes closed this Jul 7, 2017
@lukemcgregor
Copy link
Contributor Author

lukemcgregor commented Jul 7, 2017

hang on @joshgerdes i just broke it 5 mins ago, about to unbreak

@lukemcgregor lukemcgregor deleted the lukemcgregor:baseurl branch Jul 7, 2017
@adishavit

This comment has been minimized.

Copy link

adishavit commented on css/main.scss in de2cd2f Sep 4, 2017

@lukemcgregor : These two lines make the GitHub Jekyll choke and email me with:

The page build failed for the `master` branch with the following error:

Your SCSS file `css/main.scss` has an error on line 42: Invalid CSS after " border-collapse": expected ";", was ": collapse;". For more information, see https://help.github.com/articles/page-build-failed-invalid-sass-or-scss/.

For information on troubleshooting Jekyll see:

  https://help.github.com/articles/troubleshooting-jekyll-builds

If you have any questions you can contact us by replying to this email.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.