New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown tables #64

Merged
merged 3 commits into from Aug 30, 2017

Conversation

Projects
None yet
3 participants
@lukemcgregor
Contributor

lukemcgregor commented Apr 19, 2017

  • Updated to use SASS for bundling and minification
  • Added default style for tables

image

lukemcgregor added some commits Apr 19, 2017

Bundled css using SASS
bundles and minifies css. This will make the page load slightly faster.
Sadly couldnt get sourcemaps to work though, see
jekyll/jekyll-sass-converter#12
@lukemcgregor

This comment has been minimized.

Show comment
Hide comment
@lukemcgregor

lukemcgregor Apr 19, 2017

Contributor

fixes #63

Contributor

lukemcgregor commented Apr 19, 2017

fixes #63

Added a margin to the bottom
so it sits better in amongst text

@joshgerdes joshgerdes merged commit a1d53d9 into joshgerdes:master Aug 30, 2017

@adishavit

This comment has been minimized.

Show comment
Hide comment
@adishavit

adishavit Sep 4, 2017

@lukemcgregor : These two lines make the GitHub Jekyll choke and email me with:

The page build failed for the `master` branch with the following error:

Your SCSS file `css/main.scss` has an error on line 42: Invalid CSS after " border-collapse": expected ";", was ": collapse;". For more information, see https://help.github.com/articles/page-build-failed-invalid-sass-or-scss/.

For information on troubleshooting Jekyll see:

  https://help.github.com/articles/troubleshooting-jekyll-builds

If you have any questions you can contact us by replying to this email.

adishavit commented on css/main.scss in de2cd2f Sep 4, 2017

@lukemcgregor : These two lines make the GitHub Jekyll choke and email me with:

The page build failed for the `master` branch with the following error:

Your SCSS file `css/main.scss` has an error on line 42: Invalid CSS after " border-collapse": expected ";", was ": collapse;". For more information, see https://help.github.com/articles/page-build-failed-invalid-sass-or-scss/.

For information on troubleshooting Jekyll see:

  https://help.github.com/articles/troubleshooting-jekyll-builds

If you have any questions you can contact us by replying to this email.

@lukemcgregor lukemcgregor deleted the lukemcgregor:markdown-tables branch Mar 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment