after_product_built hook #6

Merged
merged 1 commit into from Jul 29, 2011

Conversation

Projects
None yet
2 participants
@jzw
Contributor

jzw commented Jul 22, 2011

Implemented a hook that will allow users of this extension to implement an after_product_built in their product_import_decorator.rb that will get called after each product is built.

@joshmcarthur

This comment has been minimized.

Show comment Hide comment
@joshmcarthur

joshmcarthur Jul 29, 2011

Owner

Hi jzw,

Sorry I've taken so long to get to this - I meant to look at how Spree does it's hooks, and then I forgot :-(

This looks good - it's a pity there's not a nicer way of adding the hook, but class_eval'ing will do for this sort of scenario.

Thanks for your contribution!

Owner

joshmcarthur commented Jul 29, 2011

Hi jzw,

Sorry I've taken so long to get to this - I meant to look at how Spree does it's hooks, and then I forgot :-(

This looks good - it's a pity there's not a nicer way of adding the hook, but class_eval'ing will do for this sort of scenario.

Thanks for your contribution!

joshmcarthur added a commit that referenced this pull request Jul 29, 2011

Merge pull request #6 from jzw/master
after_product_built hook

@joshmcarthur joshmcarthur merged commit b845ab7 into joshmcarthur:master Jul 29, 2011

@jzw

This comment has been minimized.

Show comment Hide comment
@jzw

jzw Jul 29, 2011

Contributor

No problem, happy to help!

Contributor

jzw commented Jul 29, 2011

No problem, happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment