Skip to content

Josh Nesbitt
joshnesbitt

Organizations

@wearestac @signalbox @NHSLeadership @YorkshireDigital
May 25, 2016
@joshnesbitt
May 25, 2016
May 25, 2016
joshnesbitt deleted branch default_command at sky-uk/blackjack-toolbelt
May 25, 2016
May 25, 2016
@joshnesbitt
Make preview the default command so running "bj" doesn't perform a no-op
1 commit with 1 addition and 1 deletion
May 25, 2016
May 25, 2016
May 25, 2016
@joshnesbitt
Add Babel-Polyfill to preview config
May 25, 2016
@joshnesbitt
Add Babel-Polyfill to preview config
May 25, 2016
@joshnesbitt

Fixed in #57.

joshnesbitt deleted branch IE-polyfill-hot-reload at sky-uk/blackjack-toolbelt
May 25, 2016
May 25, 2016
@joshnesbitt
May 25, 2016
@joshnesbitt
Added polyfill so that hot reloading works in IE
1 commit with 3 additions and 0 deletions
May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

Yeah I understand. I wonder if they could be defined in another part of the package.json file, like we do the preview path? I'm not too fussed eith…

May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

I like having the dependency for React in the package.json but I think there's concerns about conflicting versions when integrating the component i…

May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

Just waiting on @mackstar to weigh in on the react dependency situation then we can look at getting this merged. Thanks @romidane!

May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

Yup agree.

May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

👍

May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

Why not just 'NODE_ENV': 'production'?

May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

Because we're using webpack-hot-middleware instead?

May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

Do we need to add these in the generated package.json? I know @mackstar was keen to remove these from there.

May 25, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

Is this intentional?

May 24, 2016
@joshnesbitt
May 24, 2016
@joshnesbitt
  • @joshnesbitt 3ef861d
    Upgrade pusher integration.
joshnesbitt deleted branch karma-coverage-reports at sky-uk/blackjack-toolbelt
May 24, 2016
May 24, 2016
@joshnesbitt
May 24, 2016
@joshnesbitt
Karma code coverage reports.
1 commit with 19 additions and 7 deletions
May 24, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#56
@joshnesbitt

:shipit:

May 23, 2016
joshnesbitt commented on pull request sky-uk/blackjack-toolbelt#55
@joshnesbitt

Great stuff. In meetings today but will try and check this out properly soon!

May 23, 2016
@joshnesbitt

Released you a new gem version, 1.1.0 @lukeasrodgers.

Something went wrong with that request. Please try again.