New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature idea: Highlight toolbar buttons when cursor on text #11

Open
briangershon opened this Issue Jun 18, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@briangershon

briangershon commented Jun 18, 2012

A nice feature would be to highlight toolbar buttons to appropriate state when cursor is on text. e.g. if cursor is on text that is bold, the [B] toolbar button would be highlighted.

@joshontheweb

This comment has been minimized.

Show comment
Hide comment
@joshontheweb

joshontheweb Jun 18, 2012

Owner

I tried to make this happen when I first built etch since the api seems to allow for it. I can't remember exactly why I gave up but it got overly complicated. I think it was due to the situations where you have multiple tags wrapping a single text range but I can't be sure now.

Owner

joshontheweb commented Jun 18, 2012

I tried to make this happen when I first built etch since the api seems to allow for it. I can't remember exactly why I gave up but it got overly complicated. I think it was due to the situations where you have multiple tags wrapping a single text range but I can't be sure now.

@rickyrauch

This comment has been minimized.

Show comment
Hide comment
@rickyrauch

rickyrauch Dec 23, 2012

@joshontheweb Hey Josh, great project. Any idea how can I easily implement this? I don't want the editor all the time present.

I only what to show the editor when some text is selected.

Again, great project.

rickyrauch commented Dec 23, 2012

@joshontheweb Hey Josh, great project. Any idea how can I easily implement this? I don't want the editor all the time present.

I only what to show the editor when some text is selected.

Again, great project.

@joshontheweb

This comment has been minimized.

Show comment
Hide comment
@joshontheweb

joshontheweb Dec 29, 2012

Owner

@ricardorauch I'm confused, is this a question related to highlighting tool bar buttons? Or are you asking a separate question about how to make the toolbar only show up when text is selected? To do that, you'd have to override etch.editableInit to check if the selection is popuplated.

Owner

joshontheweb commented Dec 29, 2012

@ricardorauch I'm confused, is this a question related to highlighting tool bar buttons? Or are you asking a separate question about how to make the toolbar only show up when text is selected? To do that, you'd have to override etch.editableInit to check if the selection is popuplated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment