New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Image Uploading, Cropping and Insertion - already built, just needs some work" #23

Open
gebrits opened this Issue Jan 22, 2014 · 8 comments

Comments

Projects
None yet
5 participants
@gebrits

gebrits commented Jan 22, 2014

Read the above line in the docs. Is this still planned, since the repo seems a bit abandoned.

I might be able to put in some work to get a pull request going if I know where to start.

@joshontheweb

This comment has been minimized.

Show comment
Hide comment
@joshontheweb

joshontheweb Jan 22, 2014

Owner

The problem here is that you need a backend server with an api that can do the image processing so it isn't all just front-end code. That brings a lot of extra weight to the project and would introduce an opinion of what backend stack to use. It is starting to look like it might be possible to do the image processing on the front-end using the canvas api. I have been waiting for some time to explore that option. Any thoughts on what would best suit your needs?

Owner

joshontheweb commented Jan 22, 2014

The problem here is that you need a backend server with an api that can do the image processing so it isn't all just front-end code. That brings a lot of extra weight to the project and would introduce an opinion of what backend stack to use. It is starting to look like it might be possible to do the image processing on the front-end using the canvas api. I have been waiting for some time to explore that option. Any thoughts on what would best suit your needs?

@mlncn

This comment has been minimized.

Show comment
Hide comment
@mlncn

mlncn Jan 22, 2014

ImageScale would be happy to help support this with an implementation of the back-end cropping etc. as a service.

mlncn commented Jan 22, 2014

ImageScale would be happy to help support this with an implementation of the back-end cropping etc. as a service.

@gebrits

This comment has been minimized.

Show comment
Hide comment
@gebrits

gebrits Jan 22, 2014

I'm already using uploadcare as the BaaS for image processing so that would fit best personally. However, I understand the opinion this would introduce.

How about an idea similar to Backbone.sync, let's call it Etch.sync, in which the backend of choice if abstracted away by a simple interface that needs to be implemented per backend? This footprint of this interface would be really small imo.

While we're at at: I've been thinking about other widgets/editors that need some backend interaction. Take an asset-picker for instance. These could follow a similar regime.

What do you think?

gebrits commented Jan 22, 2014

I'm already using uploadcare as the BaaS for image processing so that would fit best personally. However, I understand the opinion this would introduce.

How about an idea similar to Backbone.sync, let's call it Etch.sync, in which the backend of choice if abstracted away by a simple interface that needs to be implemented per backend? This footprint of this interface would be really small imo.

While we're at at: I've been thinking about other widgets/editors that need some backend interaction. Take an asset-picker for instance. These could follow a similar regime.

What do you think?

@mlncn

This comment has been minimized.

Show comment
Hide comment
@mlncn

mlncn Jan 23, 2014

Like the idea of abstracting the backend. Be good to have a few implementations out of the gate. Uploading / getting from a URL, storage, and processing might be handled by a three different things, two, or one.

mlncn commented Jan 23, 2014

Like the idea of abstracting the backend. Be good to have a few implementations out of the gate. Uploading / getting from a URL, storage, and processing might be handled by a three different things, two, or one.

@joshontheweb

This comment has been minimized.

Show comment
Hide comment
@joshontheweb

joshontheweb Jan 23, 2014

Owner

I think that having an abstract image processing sync object makes sense. I will try and push some code I have been working on this weekend. It allows you to upload an image from your filesystem, a url, or search flickr. Then you could send the image to the image processing sync function which would either return a url or a base64 encoded image.

Owner

joshontheweb commented Jan 23, 2014

I think that having an abstract image processing sync object makes sense. I will try and push some code I have been working on this weekend. It allows you to upload an image from your filesystem, a url, or search flickr. Then you could send the image to the image processing sync function which would either return a url or a base64 encoded image.

@mcanthony

This comment has been minimized.

Show comment
Hide comment
@mcanthony

mcanthony Jan 3, 2015

What do you think about using local storage and client side API to do the image processing by default, and this can be overridden by the aforementioned backend processor?

mcanthony commented Jan 3, 2015

What do you think about using local storage and client side API to do the image processing by default, and this can be overridden by the aforementioned backend processor?

@sspickle

This comment has been minimized.

Show comment
Hide comment
@sspickle

sspickle Aug 12, 2017

I need to work on image support. I'm trying to grasp the intent of the image handling code in the repo. I see references to ImageUploader and ImageEditor, but it's not clear to me how to implement these. Or even how to get my own image uploader/editor wired into the etch UI. Hints? I'd be happy to supply some kind of generic example when I get it working. Or maybe it's already around somewhere and I'm just having trouble finding it?

sspickle commented Aug 12, 2017

I need to work on image support. I'm trying to grasp the intent of the image handling code in the repo. I see references to ImageUploader and ImageEditor, but it's not clear to me how to implement these. Or even how to get my own image uploader/editor wired into the etch UI. Hints? I'd be happy to supply some kind of generic example when I get it working. Or maybe it's already around somewhere and I'm just having trouble finding it?

@joshontheweb

This comment has been minimized.

Show comment
Hide comment
@joshontheweb

joshontheweb Sep 2, 2017

Owner

@sspickle the difficulty with the image code is that it requires a server-side api for processing the images and also hosting them. I think that nowadays it could be possible to do this all in the browser using canvas and base64 encoded images that are dropped right into the html so no server is would be needed. I never got this far along with it. I'm happy to share what I had though it is on a different computer atm. I'll have to dig it up.

Owner

joshontheweb commented Sep 2, 2017

@sspickle the difficulty with the image code is that it requires a server-side api for processing the images and also hosting them. I think that nowadays it could be possible to do this all in the browser using canvas and base64 encoded images that are dropped right into the html so no server is would be needed. I never got this far along with it. I'm happy to share what I had though it is on a different computer atm. I'll have to dig it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment