Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Doesn't work correctly with latest qunit #3

Closed
juamei opened this Issue · 1 comment

2 participants

@juamei

QUnit has added a QUnit.diff function since specit was originally written which dies on equality comparisons when using specit. This due to missing parameters on nativeShould and nativeShouldNot which have been added to the prototype of Object by specit.

There is also an issue if those prototype assignments are removed and a secondary function is created to replace the actual.should( comparison, expected ) construct with expected( actual, should, comparison, expected ). The qunit equal test now works but on a pass returns the appended fail string eg "expect "blah", result "blah", dif... ".
This is due to the casting of string literals to String objects by use of call and apply in specit which causes a secondary equality check within qunit to fail and hence append the fail message to a passing test.

@joshuaclayton

Add an assert method, which wraps getting a value.

  • This allows for the removal of all the should/shouldNot pollution on various prototypes.
  • This fixes issues with the latest version of qunit
  • Closed by b5e61cb
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.