Joshua Clayton joshuaclayton

Organizations

@thoughtbot @rubygems @blueprintcss @coderwall-lemmings1000 @coderwall-changelogd @coderwall-forked100 @coderwall-philanthropist
@joshuaclayton
@joshuaclayton
Cleanup gemspec
joshuaclayton commented on pull request thoughtbot/factory_girl#771
@joshuaclayton

@yoshiokatsuneo can you provide a bit more context with where you'd be introducing the debugger (in the factory definition block itself vs in attri…

@joshuaclayton
Mention coaching
joshuaclayton commented on pull request thoughtbot/factory_girl#759
@joshuaclayton

Thanks @jferris - merged as 2fe887d

@joshuaclayton
@joshuaclayton
Add Rubinius to Build Matrix with Allowed Failure
joshuaclayton commented on pull request thoughtbot/factory_girl#748
@joshuaclayton

@bjfish - thanks, merged as ed84cda

@joshuaclayton
  • @bjfish ed84cda
    Add Rubinius to Build Matrix
joshuaclayton commented on pull request thoughtbot/factory_girl#749
@joshuaclayton

@bradx3 thanks for bringing this up - it's been on my mind for a while, and I'm often confused as to why we'd gone down the path of there being dif…

@joshuaclayton
Fix warnings
joshuaclayton commented on pull request thoughtbot/factory_girl#773
@joshuaclayton

@clemcke combinations of traits seem like it'd add too much overhead/time to the point where these wouldn't be useful - I'm also unsure that there'…

joshuaclayton commented on pull request thoughtbot/factory_girl#760
@joshuaclayton

Merged as 37d6198

@joshuaclayton
@joshuaclayton
Formatting
joshuaclayton commented on pull request thoughtbot/factory_girl#762
@joshuaclayton

@rubyengineer we've actually been gradually moving back to double-quotes, so I'm going to close this without merging. Thanks!

joshuaclayton commented on pull request thoughtbot/factory_girl#760
@joshuaclayton

@chastell thanks for pointing that out - @agrimm mind making that update, squashing commits, and rebasing against master so we can get this merged?

joshuaclayton commented on pull request thoughtbot/factory_girl#773
@joshuaclayton

@clemcke I like the direction this is going; I do think it's important to also include information about the trait that's incorrect, in addition to…

@joshuaclayton
@joshuaclayton
  • @joshuaclayton 3c6a2ec
    Reference thoughtbot's open-source code of conduct in CONTRIBUTING.md
@joshuaclayton
  • @joshuaclayton 5a88048
    Reference thoughtbot's open-source code of conduct in CONTRIBUTING.md
joshuaclayton commented on pull request thoughtbot/factory_girl#748
@joshuaclayton

@bjfish thanks again for handling this - can you rebase against master and verify everything looks good on Travis?

@joshuaclayton
Updated travis.yml with ruby 2.2
joshuaclayton commented on pull request thoughtbot/factory_girl#737
@joshuaclayton

Resolved with 948238f

joshuaclayton deleted branch jc-handle-symbol-to-proc-dynamic-attributes at thoughtbot/factory_girl
@joshuaclayton
  • @joshuaclayton 930c21a
    Check arity to allow for Symbol#to_proc with dynamic attributes
@joshuaclayton
Check arity to allow for Symbol#to_proc with dynamic attributes
1 commit with 37 additions and 1 deletion
@joshuaclayton
"no receiver given" when trying to use short form for dynamic attributes
@joshuaclayton
  • @joshuaclayton 930c21a
    Check arity to allow for Symbol#to_proc with dynamic attributes
@joshuaclayton