Skip to content

joshuacoles

  • Joined on Aug 12, 2012
May 30, 2016
May 30, 2016
May 20, 2016
@joshuacoles
May 18, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

Fixed locally.

May 18, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

Ah ok, that makes sense. Would that be preferred then over negation then?

May 18, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

I don't quite understand what you mean? Do you mean the image?

May 18, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

While in that case it a reset style would work imagine a situation with {bold.red.italic Many styles {~italic not italic} and back} if you were to …

May 17, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

@Qix- Done!

May 17, 2016
@joshuacoles
  • @joshuacoles 0f787f0
    Change negation character to `~`
May 17, 2016
joshuacoles commented on pull request Qix-/color-convert#31
@joshuacoles

Ok I have corrected the xo errors however I am slightly confused on why they didn't get tripped on my side. Anyway travis tests are passing now so …

May 17, 2016
@joshuacoles
May 17, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

No as the bold styling would affect the (with added fairies) which negation styles prevent without having to reapply the wanted styles to a new chunk.

May 17, 2016
joshuacoles opened pull request Qix-/color-convert#31
@joshuacoles
Implement rounding of rgb to keywords.
1 commit with 36 additions and 2 deletions
May 17, 2016
@joshuacoles
  • @joshuacoles e97603d
    Implement rounding of rgb to keywords.
May 17, 2016
@joshuacoles
May 17, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

Ok will push changes without for of loop. Any verdict on negations?

May 17, 2016
joshuacoles commented on issue Qix-/color-convert#28
@joshuacoles

Also (can't edit on phone) the overhead does not seem that high but I haven't directly tested

May 17, 2016
joshuacoles commented on issue Qix-/color-convert#28
@joshuacoles

Quick question: should there be a limit to how far it can be rounded? I've got it implemented I just need to get to an Internet to push.

May 16, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

Ok I have fixed everything but the for...of vs for(let i; ...) loop locally. I believe it requires an index based loop but if you can think of a wa…

May 16, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

The index of the character is required for backtracking when checking for escaping. I do not think this is provided by a for ... of. Correct me if …

May 16, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

Specifically it was for brevity. Suppose you had some text in bold however wanted one section to be normal. Instead of having to write {blue.bold I…

May 16, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

Is there anything else that need to be done to this or is it just waiting for final review?

May 9, 2016
@joshuacoles
May 9, 2016
joshuacoles created repository joshuacoles/hue-agent
May 9, 2016
May 8, 2016
@joshuacoles
May 2, 2016
@joshuacoles
May 2, 2016
joshuacoles commented on pull request chalk/chalk-cli#4
@joshuacoles

So just added tests and other things as well as fixed some bugs with the parsing. True ! is a special character so that might be an issue but then …

Something went wrong with that request. Please try again.