Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
- Brooklyn, NYC
- Sign in to view email
- http://www.joshuakgoldberg.com
Pinned
7,755 contributions in the last year
Activity overview
Contributed to
typescript-eslint/tslint-to-eslint-config,
Codecademy/client-modules,
JoshuaKGoldberg/TypeStat
and 5 other
repositories
Contribution activity
June 1, 2020
JoshuaKGoldberg has no activity
yet for this period.
May 2020
- JoshuaKGoldberg/xterm.js TypeScript
- JoshuaKGoldberg/ts-repro-project-narrowing TypeScript
Created a pull request in Codecademy/client-modules that received 5 comments
feat(gamut-styles): Added TypeScript .d.ts generation to gamut-styles
Added TypeScript .d.ts generation to gamut-styles The generated `.d.ts` uses `namespace`s for some reason. export namespace colors { export const b…
+14
−6
•
5
comments
- v1 Stable Release
- Fixed crash when ESLint rule has multiple rule arguments
- Corrected NPM_TOKEN setting in CircleCI
- Used @types/eslint-config-prettier instead of manual .d.ts
- Added Codelyzer prefer-on-push-component-change-detection converter
- Added Codelyzer template-use-track-by-function converter
- Added Codelyzer template-no-negated-async converter
- Added Codelyzer template-no-distracting-elements converter
- Added Codelyzer template-no-call-expression converter
- Added Codelyzer template-no-autofocus converter
- Added Codelyzer template-no-any converter
- Added Codelyzer template-mouse-events-have-key-events converter
- Added Codelyzer template-click-events-have-key-events converter
- Added Codelyzer template-banana-in-box converter
- Added Codelyzer template-accessibility-valid-aria converter
- Added Codelyzer template-accessibility-table-scope converter
- Added Codelyzer template-accessibility-tabindex-no-positive converter
- Added Codelyzer template-accessibility-elements-content converter
- Added Codelyzer template-accessibility-alt-text converter
- Added Codelyzer relative-url-prefix converter
- Added Codelyzer prefer-output-readonly converter
- Added Codelyzer no-unused-css converter
- Added Codelyzer no-queries-metadata-property converter
- Added Codelyzer no-pipe-impure converter
- Added Codelyzer no-outputs-metadata-property converter
- Some pull requests not shown.
- chore(Gamut)!: Removed deprecated color variables
- feat(Gamut)!: Added underlines to Text links
- feat(Gamut): Allowed general text inputs for GridForm
- chore: Replaced 'Title' with 'Overview' in PR template
- fix(Gamut): Hid SkipToContent's down arrow from narration
- chore: Repurposed and renamed brand-components into gamut-labs ⚗️
- fix(Gamut): Correctly hooked up GridForm's radio-group inputs for validation updates
- feat(Brand): Ported common Loading icon to Brand/Labs
- feat(Gamut)!: Added text-decoration: underline to Markdown links
- feat(Gamut): Allowed GridForm to not take in any fields
- fix(Gamut): Fixed prettier issue on master
- feat(Gamut): Allowed Alert to receive a class name
- feat(Gamut): Allowed GridForm text fields to be of type 'date'
- feat(styleguide): Added Components documentation
- fix(styleguide): Corrected terrible couple/few typo in Platform colors
- feat(Gamut): Created separate bucket for "Platform" colors
- fix(styleguide): Slightly changed brand colors to be from color grid
- chore(Gamut): Removed unused deprecated button themes
- fix(Gamut): Removed unnecessary useEffect registers in GridForm
- fix(Gamut): vague attempt: added setValues back to all GridForm fields
- feat: Align brand color aliases [WEB-215]
- fix: remove alt text on Testimonial avatars
- ci: move changelog generation to commit hook
- fix: Overlay click-outside functionality was still not working after previous update
- ci: script to rebuild changelogs on publish [WEB-891]
- ci: run git gc before saving cache
- fix: preserve display name on card shell
- feat!: refactor Modal and Overlay components [GM-24]
- feat(GridForm): Update GridFormField label type to accept ReactNodes
- feat(Gamut): Add docs/command for working with Gamut pre-publish
- fix(Gamut): Pass down error to GridFormCustomInput
- feat(Gamut): Disable GridForm submit until required field are complete
- chore(Styleguide): Update tabs stories to MDX
- chore: Add recommendation for styled-components highlighting extension
- feat(Header): Hide header on print views
- feat(Styleguide): Convert All Stories to MDX
- fix(webpack-config): Fix misplaced filename config in extracted CSS
- chore: Repurposed and renamed brand-components into gamut-labs ⚗️
- feat(Gamut): Checkbox default style changes and add multiline prop
- feat(Gamut): Add Input Stepper
- Migrated Badge Atom to MDX
- feat!: remove appbartab and make headertab simpler/accessible
- style: allow Testimonial card to be full width with new prop
- feat(Gamut): Allow GridFormCheckboxInput to take in a ReactNode as its label
- fix(Stylgeuide): About example links
- Some pull request reviews not shown.
- Update typescript-eslint monorepo to v3 (major)
- Corrected NPM_TOKEN setting in CircleCI
- Add codelyzer no-conflicting-lifecycle converter
- Add codelyzer no-input-prefix converter
- Add codelyzer component-max-inline-declarations converter
- Add codelyzer component-selector converter
- Prefer @typescript-eslint/dot-notation to native ESLint version
- Prefer @typescript-eslint/no-unused-expression
- Add codelyzer component-class-suffix converter
- fix: Missing domain in error messages
Created an issue in microsoft/TypeScript that received 5 comments
Type narrowing not applied when in composite (-b) mode
TypeScript Version: 3.9.1-rc Search Terms: type narrowing composite build project references undefined Code export const watA = (value: string | Error
5
comments
- Use @types/eslint-config-prettier
- Empty objects from extended configurations are added to output ESLint configurations
- CLI says "--comment" but it's actually "--comments"
- Recognize tslint-react as an extended ruleset
- Missing tslint-react rule: jsx-wrap-multiline
- Missing tslint-react rule: jsx-space-before-trailing-slash
- Missing tslint-react rule: jsx-self-close
- Missing tslint-react rule: jsx-no-multiline-js
- Missing tslint-react rule: jsx-no-lambda
- Missing tslint-react rule: jsx-no-bind
- Missing tslint-react rule: jsx-key
- Missing tslint-react rule: jsx-equals-spacing
- Missing tslint-react rule: jsx-curly-spacing
- Missing tslint-react rule: jsx-boolean-value
- Missing tslint-react rule: jsx-ban-props
- Missing tslint-react rule: jsx-ban-elements
- Missing tslint-react rule: jsx-alignment
- Add issues for converters for React rules
- Missing Codelyzer (Angular) rule: use-component-view-encapsulation
- Missing Codelyzer (Angular) rule: use-component-selector
- Missing Codelyzer (Angular) rule: template-use-track-by-function
- Missing Codelyzer (Angular) rule: template-no-negated-async
- Missing Codelyzr (Angular) rule: template-no-distracting-elements
- Missing Codelyzr (Angular) rule: template-no-call-expression
- Missing Codelyzr (Angular) rule: template-no-autofocus
- Some issues not shown.
- This should really be named mock-react-redux
- Errors in older node environments for export * syntax
- Support default imports
- Throw errors on other unsupported APIs provided by react-redux
- Investigate Provider support
- Support connect() usage
- Allow inline selectors
- Create some kind of "docs/Philosophy.md" page
397
contributions
in private repositories
May 1 – May 29