Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add periodicity argument to getSymbols.yahoo #162

Closed
joshuaulrich opened this issue May 23, 2017 · 0 comments
Closed

Add periodicity argument to getSymbols.yahoo #162

joshuaulrich opened this issue May 23, 2017 · 0 comments
Assignees
Milestone

Comments

@joshuaulrich
Copy link
Owner

Kurt Hornik expressed an interest in being able to use getSymbols.yahoo() as a drop-in replacement for tseries::get.hist.quote(). Email snippet below:

>> Last night I looked at the possibility of changing
>> tseries::get.hist.quote() on top of quantmod::getSymbols (yahoo, in
>> essence), to move towards a single point of failure :-)
>>
> I've thought about that too, because I also have TTR::getYahooData().
> My thought is to deprecate that function and suggest people use
> getSymbols.yahoo() instead.

Sounds like a plan :-)

>> There is one "issue": get.hist.quote() has a 'compression' argument,
>> with comment
>>
>> ## Added new argument 'compression'.
>> ## May be "d", "w" or "m", for daily weekly or monthly.
>> ## Defaults to "d".
>> ## John Bollinger, 2004-10-27, www.BollingerBands.com, bbands@yahoo.com
>>
>> and then added as
>>
>> "&g=", compression,
>>
>> to the query.  If this is still "in place", would it possibly to enhance
>> getSymbols.yahoo() accordingly?
>>
> getSymbols.yahoo() doesn't currently have a notion of "compression",
> but the Yahoo URL does.  You just need to specify the interval as one
> of: 1d, 1wk, 1mo.
> So I could add a "periodicity" argument to getSymbols.yahoo() after
> "..." to allow you to specify daily, weekly, or monthly.

That would be perfect!
@joshuaulrich joshuaulrich added this to the 0.4-9 milestone May 23, 2017
@joshuaulrich joshuaulrich self-assigned this May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant