Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: enable getSymbols.av to retrieve weekly adjusted data #212

Closed
weekend325 opened this issue Jan 11, 2018 · 1 comment
Closed
Assignees

Comments

@weekend325
Copy link

@weekend325 weekend325 commented Jan 11, 2018

Description

Presently, when requesting adjusted data, passing any periodicity argument to getSymbols.av other than "daily" results in the error "Only daily data can be adjusted". (Presently, lines 1304-1305 of getSymbols.R).

However, alpha vantage has added monthly and weekly adjusted time series, namely, TIME_SERIES_WEEKLY_ADJUSTED etc.

Is there any reason that getSymbols.R cannot be modified (at approximately lines 1304-1314) to allow getSymbols.av to access TIME_SERIES_WEEKLY_ADJUSTED if adjusted weekly data is requested?

@joshuaulrich
Copy link
Owner

@joshuaulrich joshuaulrich commented Apr 1, 2018

Thanks for letting me know they've added that functionality to their API! I also see they've added monthly adjusted time series too, so I've included that in my patch.

Thanks for your contribution!

@joshuaulrich joshuaulrich self-assigned this Apr 1, 2018
@joshuaulrich joshuaulrich added this to the Release 0.4-13 milestone Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.