Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend getQuote to support tiingo #247

Closed
ethanbsmith opened this issue Sep 21, 2018 · 1 comment
Closed

extend getQuote to support tiingo #247

ethanbsmith opened this issue Sep 21, 2018 · 1 comment

Comments

@ethanbsmith
Copy link
Contributor

@ethanbsmith ethanbsmith commented Sep 21, 2018

I'm going to work up a PR for getQuote functionality for tiingo. I have a simple version working already, but there are a few design decisions i'd like some feedback on first:

tiingo returns 17 columns that are documented at https://api.tiingo.com/docs/iex/realtime#realtimeData . This raises the following questions:

  1. Should column names like LastsaleTimeStamp be changed to Trade Time and first letter of column names be upper cased to make is more of a direct substitute for the yahoo and av versions? my vote on this would be yes to case changes and no on column names changes, but to add a Trade Time that is a copy of LastsaleTimeStamp
  2. tiingo returns 17 columns should all columns be passed through to the caller, or should it just default to OHLCV and the what functionality from yahoo version be supported? my vote if to return all 17 as its not overly burdensome and has no impact on performance. I will reorder the columns to put OHLCV first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants