Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove disk i/o from getSymbols and getQuote functions #280

Closed
ethanbsmith opened this issue Oct 15, 2019 · 0 comments · Fixed by #281
Closed

remove disk i/o from getSymbols and getQuote functions #280

ethanbsmith opened this issue Oct 15, 2019 · 0 comments · Fixed by #281
Milestone
Release 0.4-16

Comments

@ethanbsmith
Copy link
Contributor

replace download.file(url, tmp) read.csv(tmp) pattern with read.csv(curl::curl(url))
replace download.file(url, tmp) fromJSON(tmp) pattern with fromJSON(curl::curl(url))

tested to work with existing quantmod dependencies in R 3.2
Capture
@ethanbsmith ethanbsmith mentioned this issue Oct 17, 2019
Merged
joshuaulrich pushed a commit that referenced this issue Nov 3, 2019
@ethanbsmith @joshuaulrich
Remove file I/O
1739987 
There's no need to download to disk then read from disk, because
read.csv() and fromJSON() can read directly from curl::curl() and/or a
URL. Thanks to Ethan Smith for the issue and PR.

Fixes #280.
Closes #281.
@joshuaulrich joshuaulrich added this to the Release 0.4-16 milestone Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.4-16
Development

Successfully merging a pull request may close this issue.

280 remove file io
2 participants
@joshuaulrich @ethanbsmith