Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide API keys in error messages #286

Closed
joshuaulrich opened this issue Nov 6, 2019 · 0 comments
Closed

Hide API keys in error messages #286

joshuaulrich opened this issue Nov 6, 2019 · 0 comments

Comments

@joshuaulrich
Copy link
Owner

joshuaulrich commented Nov 6, 2019

Error messages contain API keys in plain text. This is a problem for tests that are run on TravisCI, or any other CI platform where the logs are public.

Here are a couple examples:

quantmod::getQuote(c("FOO", "WYSIWYG"), src = "av", api.key = v)
Error in getQuote.av(Symbols = c("FOO", "WYSIWYG"), api.key = "[redacted]") : 
  No data for symbols: FOO, WYSIWYG

quantmod::getQuote(c("FOO", "WYSIWYG"), src = "tiingo", api.key = k)
Error in getQuote.tiingo(Symbols = c("FOO", "WYSIWYG"), api.key = "[redacted]") : 
  No data for symbols: FOO, WYSIWYG

The fix may be as easy as setting call. = FALSE in the call to stop().

@joshuaulrich joshuaulrich added this to the Release 0.4-16 milestone Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant