Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFX returns 404 error #36

Closed
andharris opened this issue Feb 6, 2015 · 2 comments
Closed

getFX returns 404 error #36

andharris opened this issue Feb 6, 2015 · 2 comments
Assignees
Labels
bug

Comments

@andharris
Copy link

@andharris andharris commented Feb 6, 2015

It looks like OANDA updated it's URL and page structure which has broken getFX where it is returning a 404 error.

@joshuaulrich
Copy link
Owner

@joshuaulrich joshuaulrich commented Feb 7, 2015

Thanks for the report.

Here's an example of the new URL: http://www.oanda.com/currency/historical-rates/download?quote_currency=USD&end_date=2015-2-7&start_date=2015-1-9&period=daily&display=absolute&rate=0&data_range=d30&price=bid&view=table&base_currency_0=EUR&base_currency_1=&base_currency_2=&base_currency_3=&base_currency_4=&download=csv

I'm not familiar with the format of the data from the previous download link. That might have also changed and would require changes to how the CSV is read.

@joshuaulrich joshuaulrich added the bug label Feb 7, 2015
@joshuaulrich joshuaulrich self-assigned this Feb 7, 2015
joshuaulrich added a commit that referenced this issue Mar 2, 2015
Oanda changed their URL structure and CSV file format. This change
addresses both issues in getSymbols.oanda
@joshuaulrich joshuaulrich mentioned this issue Mar 25, 2015
@isomorphisms
Copy link

@isomorphisms isomorphisms commented May 13, 2015

Thanks Josh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.