Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getQuote.R #223

Merged
merged 1 commit into from Apr 7, 2018

Conversation

Projects
None yet
2 participants
@ethanbsmith
Copy link
Contributor

ethanbsmith commented Apr 3, 2018

added support for AV batch quotes by extending getQuote with getQuote.av

@ethanbsmith

This comment has been minimized.

Copy link
Contributor Author

ethanbsmith commented Apr 3, 2018

fixes #213

@ethanbsmith

This comment has been minimized.

Copy link
Contributor Author

ethanbsmith commented Apr 6, 2018

@joshuaulrich Im still new at this whole github thing, but it looks to me like the CI test is failing on a google getSymbols call. At this point Im not sure what to do, so will wait for your input. thx.

@joshuaulrich

This comment has been minimized.

Copy link
Owner

joshuaulrich commented Apr 6, 2018

It's not you, it's Google. I'll re-run this build.

Add getQuote.alphavantage()
Alpha Vantage added support for current price quotes from multiple
symbols in January, 2017. It is similar to getQuote() from Yahoo, and
also provides real-time quotes (vs Yahoo's delayed data).

The API only handles up to 100 symbols. And the output is slightly
different from the Yahoo version. The single-ticker API includes
timestamp, symbol, price, and volume; the multi-ticker API only
includes timestamp, symbol, and price.  Where Yahoo has a couple
dozen potential columns, and is the same for one or more tickers.

Fixes #213.
@joshuaulrich

This comment has been minimized.

Copy link
Owner

joshuaulrich commented Apr 7, 2018

@ethanbsmith can you please give me permission to push to the PR branch in your forked repository? See, "Allowing changes to a pull request branch created from a fork".

You branched from the commit after v0.4-11, so I have rebased the branch and squashed the 3 commits. We can close this PR as "merged" if I can push to the PR branch, but will be marked as "closed" if I merge my local branch.

@ethanbsmith

This comment has been minimized.

Copy link
Contributor Author

ethanbsmith commented Apr 7, 2018

should be good. let me know if u need anything else

@joshuaulrich joshuaulrich force-pushed the ethanbsmith:add_getQuote.av branch from 3599331 to 5bb76f6 Apr 7, 2018

@joshuaulrich joshuaulrich merged commit 5bb76f6 into joshuaulrich:master Apr 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joshuaulrich joshuaulrich added this to the Release 0.4-13 milestone Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.