Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getQuote.yahoo for multiple timezones #248

Merged

Conversation

@pverspeelt
Copy link
Contributor

@pverspeelt pverspeelt commented Oct 8, 2018

When getQuote.yahoo was called it genereted errors when quotes from multiple timezones were involved. Fixed so everything is forced to the local timezone.

Following code now works correctly:

library(quantmod)
metrics <- yahooQF(c("Name", "Volume", "P/E Ratio", "Dividend Yield", "Shares Outstanding"))
symbols <- c("MSFT", "GOOG", "FAGR.BR")
stats <- getQuote(symbols, what = metrics)

Fixes #246

When getQuote.yahoo was called it genereted errors when quotes from multiple timezones were involved. Fixed so everything is forced to the local timezone

Fixes #246
@joshuaulrich joshuaulrich merged commit 3451f11 into joshuaulrich:master Oct 8, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pverspeelt pverspeelt deleted the pverspeelt:246_fixing_getQuote.yahoo branch Oct 8, 2018
@joshuaulrich joshuaulrich added this to the Release 0.4-14 milestone Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.