Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getQuote.yahoo for multiple timezones #248

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix getQuote.yahoo for multiple timezones #248

merged 1 commit into from
Oct 8, 2018

Conversation

pverspeelt
Copy link
Contributor

When getQuote.yahoo was called it genereted errors when quotes from multiple timezones were involved. Fixed so everything is forced to the local timezone.

Following code now works correctly:

library(quantmod)
metrics <- yahooQF(c("Name", "Volume", "P/E Ratio", "Dividend Yield", "Shares Outstanding"))
symbols <- c("MSFT", "GOOG", "FAGR.BR")
stats <- getQuote(symbols, what = metrics)

Fixes #246

@pverspeelt
Fix getQuote.yahoo for multiple timezones
3451f11 
When getQuote.yahoo was called it genereted errors when quotes from multiple timezones were involved. Fixed so everything is forced to the local timezone

Fixes joshuaulrich#246
@joshuaulrich joshuaulrich merged commit 3451f11 into joshuaulrich:master Oct 8, 2018
@pverspeelt pverspeelt deleted the 246_fixing_getQuote.yahoo branch October 8, 2018 11:25
@joshuaulrich joshuaulrich added this to the Release 0.4-14 milestone Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.4-14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pverspeelt @joshuaulrich