Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

247 getquote tiingo #250

Merged
merged 8 commits into from Nov 10, 2018

Conversation

Projects
None yet
2 participants
@ethanbsmith
Copy link
Contributor

ethanbsmith commented Oct 13, 2018

No description provided.

@ethanbsmith

This comment has been minimized.

Copy link
Contributor Author

ethanbsmith commented Oct 13, 2018

solves #247

ethanbsmith added some commits Sep 23, 2018

Add Tiingo as getQuote() source
Initial version. Waiting on feedback about correct batch size from
Tiingo.

See #247.
Import all symbols if Symbols = NULL
Add support for getting all symbols with NULL symbols parameter.

See #247.
@joshuaulrich

This comment has been minimized.

Copy link
Owner

joshuaulrich commented Nov 8, 2018

Thanks for the PR! There are a few cosmetic things I would change, and I would like to refactor to avoid the code duplication in the is.null(Symbols) if/else blocks. I can take care of these if you can give me push access to this branch.

I would also like to rebase to merge your two 'fixup' commits, and amend some of the commit messages. Is that okay with you? It might cause you some grief when you update your local copy.

@ethanbsmith

This comment has been minimized.

Copy link
Contributor Author

ethanbsmith commented Nov 8, 2018

have at it. i have "allow edits for maintainers" checked. is that what you need?

@joshuaulrich

This comment has been minimized.

Copy link
Owner

joshuaulrich commented Nov 8, 2018

Yep, thanks!

ethanbsmith and others added some commits Nov 9, 2018

Fix column name typo and avoid $ subset
The `$` data.frame subset method does partial column name matching,
and returns NULL if the column name is not found. The `[` data.frame
subset method will throw an error if the column name is not found.
Fix URL if batch size is not multiple of 100
`min(Symbols,  i + batch.size - 1L)` would always return the second
argument because Symbols is a character vector. This should be
`length(Symbols)`.

Calculate the last batch observation index once at the top of the loop
and use it in the printed message and when creating the URL.

See #247.

@joshuaulrich joshuaulrich force-pushed the ethanbsmith:247_getquote_tiingo branch from 43be265 to b96afcb Nov 10, 2018

@joshuaulrich joshuaulrich merged commit b96afcb into joshuaulrich:master Nov 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

joshuaulrich added a commit that referenced this pull request Nov 10, 2018

@joshuaulrich joshuaulrich added this to the Release 0.4-14 milestone Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.