Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-column filling when first column all NA #237

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
2 participants
@TomAndrews
Copy link
Contributor

TomAndrews commented Apr 18, 2018

The firstNonNA check only checks the first column for a 2-dimensional
SEXP. Therefore if the first column is NA, the function returns
without examining any other columns.

Fix by removing this check.

Fixes #233

Fix multi-column filling when first column all NA
The firstNonNA check only checks the first column for a 2-dimensional
SEXP.  Therefore if the first column is NA, the function returns
without examining any other columns.

Fix by removing this check.

Fixes #233
@TomAndrews

This comment has been minimized.

Copy link
Contributor Author

TomAndrews commented Apr 18, 2018

This will conflict with the fix to #234 since both checks were added to the end of the file. I can rebase the other once the first is merged.

@joshuaulrich joshuaulrich merged commit ae31bda into joshuaulrich:master Apr 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joshuaulrich joshuaulrich added this to the Release 0.11-0 milestone Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.