Fix illegal read in fill_window_dups_rev #264
Merged
Conversation
Without the PROTECT you get an illegal read which sometimes causes a segfault. Fixes #263.
This looks good to me. This was a really silly error on my part. Of course I don't think |
e3120c6
into
joshuaulrich:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I'm not 100% sure this is the appropriate fix but it seems to fix my example.
'Writing R Extensions' says:
Which makes me think that the original code should be fine, but it also says:
Could
lengthgets
be triggering the garbage collection and deleting the unprotected_out
even though it's a function argument?