New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

270 fix len logic2 (#1) #272

Merged
merged 1 commit into from Sep 30, 2018

Conversation

Projects
None yet
2 participants
@HughParsonage
Contributor

HughParsonage commented Sep 27, 2018

  • Fix if class(order.by) > 1

When class(order.by) has a length other than one, it will reach this
line but only the first element will be used. We should make this
explicit and indeed must in case the environment variable R_CHECK_LENGTH_1_LOGIC2 is set, whereupon this line will emit an error
or warning.

Ensure if statement uses length-1 logical
Only the first element of class(order.by) is used in the if statement.
This will emit an error or warning when the environment variable
_R_CHECK_LENGTH_1_LOGIC2_ is true. We should make this explicit to
avoid the error or warning.

Fixes #270.

@joshuaulrich joshuaulrich merged commit 4bb73f3 into joshuaulrich:master Sep 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@joshuaulrich

This comment has been minimized.

Owner

joshuaulrich commented Sep 30, 2018

Thanks for your patch! I only made a few changes to the commit message.

@joshuaulrich joshuaulrich added the bug label Sep 30, 2018

@joshuaulrich joshuaulrich added this to the 0.11-2 milestone Sep 30, 2018

@joshuaulrich joshuaulrich referenced this pull request Sep 30, 2018

Closed

270 fix len logic2 #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment