Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added queryParameters support and moved port to Uri. #25

Merged
merged 19 commits into from Mar 11, 2020

Conversation

@rafaelcmm
Copy link
Contributor

rafaelcmm commented Mar 10, 2020

Proposal

We need to enable support of queryParameters in GET requests. Since http packages already provides us, we just need to add it on our GET interface

What was done

  • Added queryParameter support
  • Moved port configuration to another method parameter. That way we can remove the port configuration from string url and set it directly on Uri.
  • Created QA Github action to run tests and analyze in every push
  • Some code enhancements

CHANGELOG

Added on changelog:

## 3.1.0

- BREAKING CHANGE: removed port from url. Added parameter port according to `Uri` best practices.
- feature: added queryParameter support in get requests
- feature: created Github QA workflow to prevent pushes that breaks analyze or tests
- enhancement: changed http method strings into enum to avoid errors
- enhancement: improved type of arguments to prevent unexpected errors
- enhancement: added more validations on tests
- enhancement: executed flutter format to improve pub score
- enhancement: changed some anti patterns.
@jossef
jossef approved these changes Mar 11, 2020
@jossef jossef merged commit ea191c8 into jossef:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.