-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Alexa Lists feature #1418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aswetlow
approved these changes
Sep 8, 2022
Thanks a lot @NLueg 🎉 I'll take a look at the docs early next week |
jankoenig
reviewed
Oct 6, 2022
examples/typescript/alexa/lists/src/components/GlobalComponent.ts
Outdated
Show resolved
Hide resolved
jankoenig
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @NLueg 🎉
aswetlow
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
As requested in #1251 here is the way I managed it to include the Alexa lists api with Jovo.
I've added a new documentation section for it and added an example which shows how to include it in the real world.
This PR also contains some changes to the api to make it easier to get an item from a specific list.
Lastly, it contains a small bugfix as the current permission string for Alexa lists is wrong.
I still have an issue with uploading the package, but I found a workaround for it.
I don't include the workaround here, but I could think about doing this. You can find more information about it in #1419
Can't wait for your feedback!
Types of Changes
Checklist