Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Alexa Lists feature #1418

Merged
merged 16 commits into from
Oct 18, 2022
Merged

✨ Add Alexa Lists feature #1418

merged 16 commits into from
Oct 18, 2022

Conversation

NLueg
Copy link
Contributor

@NLueg NLueg commented Sep 7, 2022

Proposed Changes

As requested in #1251 here is the way I managed it to include the Alexa lists api with Jovo.
I've added a new documentation section for it and added an example which shows how to include it in the real world.

This PR also contains some changes to the api to make it easier to get an item from a specific list.
Lastly, it contains a small bugfix as the current permission string for Alexa lists is wrong.

I still have an issue with uploading the package, but I found a workaround for it.
I don't include the workaround here, but I could think about doing this. You can find more information about it in #1419

Can't wait for your feedback!

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@jankoenig
Copy link
Member

Thanks a lot @NLueg 🎉

I'll take a look at the docs early next week

@jankoenig jankoenig changed the title V4/feature/alexa lists ✨ Add Alexa Lists feature Oct 6, 2022
@NLueg NLueg requested a review from jankoenig October 17, 2022 11:31
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @NLueg 🎉

@jankoenig jankoenig merged commit d7d039c into jovotech:v4/latest Oct 18, 2022
@NLueg NLueg deleted the v4/feature/alexa-lists branch October 19, 2022 04:35
@NLueg NLueg mentioned this pull request Oct 19, 2022
4 tasks
@NLueg NLueg mentioned this pull request Oct 19, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants