Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add app data + allow app and request data in unit tests #1421

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

jankoenig
Copy link
Member

Proposed Changes

As suggested by @rmtuckerphx, you can now use testSuite.$data to write into the jovo.$data object for request data.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@jankoenig jankoenig requested a review from aswetlow September 8, 2022 13:47
@jankoenig jankoenig changed the title ✨ Allow request data in unit tests as well ✨ Add app data + allow app and request data in unit tests Sep 8, 2022
@jankoenig jankoenig merged commit f0795a9 into v4/dev Sep 8, 2022
@jankoenig jankoenig deleted the v4/improvement/unittesting-data branch September 8, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants