Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ History items as class instances #1435

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Conversation

aswetlow
Copy link
Member

@aswetlow aswetlow commented Oct 6, 2022

Proposed Changes

Deserializes history items (request, response, input) as class instances. Feature Request: #1415

Example:
if (this.$history.prev?.request instanceof AlexaRequest) will work. this.$history.prev?.request.isNewSession() as well.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@aswetlow aswetlow merged commit cdd9ad2 into v4/dev Oct 6, 2022
@aswetlow aswetlow deleted the v4/feature/history-instance branch October 6, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants