Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Google Transactions for Digital Goods #406

Merged
merged 8 commits into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@renatoalencar
Copy link
Contributor

renatoalencar commented Mar 3, 2019

Proposed changes

Google Transactions for Digital Goods implementation, it addresses to the original issue I created here: #277. It's still missing the package entitlements handling, documentation and an example project that I expect to finish in the next few days. I'm proposing this PR in order to you guys to review it, now that it has the core feature implementation of the Digital Goods.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@renatoalencar renatoalencar force-pushed the renatoalencar:feature/digital-goods branch from 4054761 to 06858dd Mar 3, 2019

@jankoenig

This comment has been minimized.

Copy link
Member

jankoenig commented Mar 4, 2019

Thank you @renatoalencar, this is great 🔥

We will take a look today and provide feedback as fast as possible.

aswetlow added some commits Mar 4, 2019

@renatoalencar

This comment has been minimized.

Copy link
Contributor Author

renatoalencar commented Mar 5, 2019

@aswetlow, thanks for the contributions. It reflects the same stuff I was concerned about. We want to move this to the Transactions.ts module, the problem is that in order to access the digital goods transactions it would need to access something like this.$googleAction.$transaction.$digitalGoods or the $transaction object would contain all the methods for both digital and physical goods. Any suggestions?

@aswetlow

This comment has been minimized.

Copy link
Member

aswetlow commented Mar 5, 2019

Thanks for your contributions @renatoalencar!
I will merge it and move the methods to the Transaction class.

aswetlow added some commits Mar 5, 2019

@aswetlow aswetlow merged commit 8214b8c into jovotech:master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@renatoalencar renatoalencar deleted the renatoalencar:feature/digital-goods branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.