Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 28 million developers.
Sign up
Pinned repositories
2,236 contributions in the last year
Activity overview
Contribution activity
November 2018
Created a pull request in nodejs/node that received 17 comments
src: compile native modules and their code cache in C++
This PR contains two patch. The first one, a benchmark patch, is only here so that we can run the benchmark CI with more options. I have opened ano…
+680
−364
•
17
comments
- fs: handle result of access binding directly in fs.existsSync
- test: automate WPT updates with drivers in test/wpt
- console: bind methods from the prototype chain in Console
- lib: move module exports proxy into a separate method
- src: move error handling code into node_errors.cc
- lib: move internalBinding whitelisting into loaders.js
- lib: move process prototype manipulation into setupProcessObject
- src: cache the result of GetOptions() in JS land
- build: only try to run node when it's needed by the target
- src: replace pushValueToArray with pure C++ API
- url: make the context non-enumerable
- benchmark: support more options in startup benchmark
- src: remove pushValueToArray and setupProcessObject
- benchmark: pre-generate data set for URL benchmarks and use WPT test data
- benchmark: try building the addons in napi benchmarks
- doc: make C++ core guidelines a reference
- src: use STL containers instead of v8 values for static module data
- src: fix compiler warning for debug build
- lib: gather all errors constant in the same place for consistency
- doc: fix socket.connecting description
- meta,doc: ping community about new release
- child_process: allow 'http_parser' monkey patching again
- vm: add createCacheForFunction
- build: add common `defines`
- build: use BUILDTYPE in bench-addons-build targets
- test: add crypto check to test-benchmark-http2
- doc: update System Errors documentation
- build: only try to run node when it's needed by the target
- doc: add shisama to collaborators
- doc: add psmarshall to collaborators
- lib: add crypto dependant modules cannotUseCache
- test: add typeerror for vm/compileFunction params
- src: replace some deprecated uses of Get() and Set()
- tracing: fix static destruction order issue
- test: move benchmark tests out of main test suite
- src: bundle persistent-to-local methods as class
- doc: add oyyd to collaborators
- async_hooks: add HandleScopes to C++ embedder/addon API
- fs: make process.binding('fs') internal
- src: emit warnings from V8
- refactor error decoration
Created an issue in nodejs/node that received 1 comment
discussion: put subsystem, team and label metadata in file(s) in this repo
Right now there are multiple places that somewhat capture the label and subsystem metadata in this repo: In core-validate-commit: https://github.co…
1
comment
23
contributions
in private repositories
Nov 1 – Nov 9