Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOLS-2525 Everything needs to stop cloning with git:// URLs (embedded imgapi) #52

Merged
merged 1 commit into from Mar 16, 2022
Merged

TOOLS-2525 Everything needs to stop cloning with git:// URLs (embedded imgapi) #52

merged 1 commit into from Mar 16, 2022

Conversation

bahamat
Copy link
Member

@bahamat bahamat commented Mar 15, 2022

These embedded dependencies were still using git:// URLs, causing builds to fail.

danmcd
danmcd approved these changes Mar 15, 2022
View reviewed changes
Copy link

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah git+https URLs!!!

@bahamat
Copy link
Member Author

bahamat commented Mar 16, 2022

In this case, it wasn't the git+https:// (which is ok), but the fact that they were pointing at an explicit commit. (the old commits were still using git:// urls.)

@bahamat bahamat merged commit b1da8d9 into master Mar 16, 2022
@bahamat bahamat deleted the TOOLS-2525 branch March 16, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bahamat @danmcd