Browse files

OS-1433 platform node should use libumem

  • Loading branch information...
wesolows committed Aug 1, 2012
1 parent 7c9bf5b commit fc553cb0b9f3668ca6fa04c49fff5ebbed387583
Showing with 15 additions and 0 deletions.
  1. +15 −0 node.js/Makefile
@@ -28,6 +28,21 @@ include ../Makefile.defs
CFLAGS += -Wno-unknown-pragmas
+# Node's build system is super broken. If we pass it LIBS at configure time,
+# it ignores it. If we pass it LIBS at make time, it completely replaces all
+# libraries, including those the build system itself would normally add.
+# So our only option is to add this to LDFLAGS, which has to be passed at
+# build time... including for the install target, because the generated
+# makefiles have missing dependencies and rebuild stuff when installing.
+# This has to be the most complicated, baroque, pointlessly wrong way
+# imaginable to build something with a few dozen source files. The next time
+# you are here reading this and trying to work around the next piece of
+# Node build stupidity, just stop. Rip all this out, write a simple makefile,
+# and copy it in at unpack time like we do for bzip2.
+LDFLAGS += -lumem
--with-dtrace \
--openssl-use-sys \

0 comments on commit fc553cb

Please sign in to comment.