Permalink
Browse files

OS-1462 running openvpn can reliably crash smartos joyent_20120726T18…

…4637Z
  • Loading branch information...
1 parent fc553cb commit 9412039a18f2f52b24b18ad8c8642a55d3b50d93 @jjelinek jjelinek committed Aug 13, 2012
Showing with 6 additions and 6 deletions.
  1. +6 −6 tun/Makefile
  2. BIN tun/tun-1.1.tar.gz
  3. BIN tun/tun-1.3.tar.gz
View
@@ -21,7 +21,7 @@
# Copyright (c) 2012, Joyent, Inc. All rights reserved.
#
-VER = tun-1.1
+VER = tun-1.3
include ../Makefile.defs
@@ -35,8 +35,8 @@ all: all_autoconf
install: all
mkdir -p $(DESTDIR)/usr/include/net
mkdir -p $(DESTDIR)/usr/kernel/drv/amd64
- cp $(BASE)/$(VER.64)/solaris/if_tun.h $(DESTDIR)/usr/include/net
- cp $(BASE)/$(VER.64)/solaris/tap.conf $(DESTDIR)/usr/kernel/drv
- cp $(BASE)/$(VER.64)/solaris/tun.conf $(DESTDIR)/usr/kernel/drv
- cp $(BASE)/$(VER.64)/solaris/tap $(DESTDIR)/usr/kernel/drv/amd64
- cp $(BASE)/$(VER.64)/solaris/tun $(DESTDIR)/usr/kernel/drv/amd64
+ cp $(BASE)/$(VER.64)/if_tun.h $(DESTDIR)/usr/include/net
+ cp $(BASE)/$(VER.64)/tap.conf $(DESTDIR)/usr/kernel/drv
+ cp $(BASE)/$(VER.64)/tun.conf $(DESTDIR)/usr/kernel/drv
+ cp $(BASE)/$(VER.64)/tap $(DESTDIR)/usr/kernel/drv/amd64
+ cp $(BASE)/$(VER.64)/tun $(DESTDIR)/usr/kernel/drv/amd64
View
Binary file not shown.
View
Binary file not shown.

3 comments on commit 9412039

Hi,

I'm Kazuyoshi and I'm maintaining tap driver for solaris at http://www.whiteboard.ne.jp/~admin2/tuntap/
I happened to notice that you have experienced system panic due to tun/tap driver and have resolved it.
Could you please share what was the problem and how did you solve it?
I'd like to apply it to my version of tap driver if it is applicable.

Thanks in advance.

Kazuyoshi

Owner

rmustacc replied Jul 2, 2013

To keep a long story short, the ultimate problem was that the module was being built without the gcc option -mno-red-zone. While the amd64 ABI does have a red zone, it's not honored by the kernel. The solution was just to make sure that it was built with that.

Hi Robert,

Thank you for the info. I understood.
Since build script of my driver already has -mno-red-zone option for amd64, it appears same problem won't happen.
I'm relieved to know that.

Thanks again,

Kazuyoshi

Please sign in to comment.